Details
Details
- Reviewers
skreuzer
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 56691 Build 53579: arc lint + arc unit
Event Timeline
Comment Actions
Hello,
Missing dependency since version 2.3.2:
Require cpp11 >= 0.4.0 (#456).
Build error:
ERROR: dependency 'cpp11' is not available for package 'RSQLite'
Comment Actions
Actual patch doesn't apply.
I've patched using first review patch + add missing cpp11 + add testthat test depends.
test results:
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
`actual$X.a4..a4..a4..e5.2` is a character vector ('<a4><a4><a4><e5>', '<a4><a4><a4><e5>', '<a4><a4><a4><e5>')
`expected$X.a4..a4..a4..e5.2` is absent
`actual$<a4><a4><a4><e5>1` is absent
`expected$<a4><a4><a4><e5>1` is an integer vector (1, 2, 3)
`actual$<a4><a4><a4><e5>2` is absent
`expected$<a4><a4><a4><e5>2` is a character vector ('\244\244\244\345', '\244\244\244\345', '\244\244\244\345')
[ FAIL 4 | WARN 0 | SKIP 16 | PASS 670 ]
Error: Test failures
In addition: Warning message:
call dbDisconnect() when finished working with a connection
Execution halted
* DONEAny thoughts so we can preceed?
Comment Actions
Investigating test failures that occurs on 2.3.5 and 2.3.6
https://github.com/r-dbi/RSQLite/issues/502
Comment Actions
Nice, tests are fixed and it gives me more confidence that R pkg works fine.
I will upload 2.3.6 update patch soon.
Comment Actions
Can't update diff on this review, please see update to 2.3.6 instead:
https://reviews.freebsd.org/D44592
Thanks