Page MenuHomeFreeBSD

Update databases/R-cran-RSQLITE to 2.3.5
Needs ReviewPublic

Authored by einar_isnic.is on Feb 24 2024, 11:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 1:01 PM
Unknown Object (File)
Tue, Dec 24, 9:21 AM
Unknown Object (File)
Dec 4 2024, 7:58 PM
Unknown Object (File)
Dec 2 2024, 7:57 PM
Unknown Object (File)
Nov 16 2024, 6:01 PM
Unknown Object (File)
Nov 11 2024, 5:18 AM
Unknown Object (File)
Oct 6 2024, 10:59 PM
Unknown Object (File)
Oct 6 2024, 10:58 PM
Subscribers

Details

Reviewers
skreuzer

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

einar_isnic.is created this revision.
This revision is now accepted and ready to land.Mar 17 2024, 11:51 PM

Hello,

Missing dependency since version 2.3.2:

Require cpp11 >= 0.4.0 (#456).

Build error:

ERROR: dependency 'cpp11' is not available for package 'RSQLite'
  • Add missing dependency for R-cran-cpp11
This revision now requires review to proceed.Mar 19 2024, 12:17 PM

Actual patch doesn't apply.
I've patched using first review patch + add missing cpp11 + add testthat test depends.

test results:

Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:

  `actual$X.a4..a4..a4..e5.2` is a character vector ('<a4><a4><a4><e5>', '<a4><a4><a4><e5>', '<a4><a4><a4><e5>')
  `expected$X.a4..a4..a4..e5.2` is absent

  `actual$<a4><a4><a4><e5>1` is absent
  `expected$<a4><a4><a4><e5>1` is an integer vector (1, 2, 3)

  `actual$<a4><a4><a4><e5>2` is absent
  `expected$<a4><a4><a4><e5>2` is a character vector ('\244\244\244\345', '\244\244\244\345', '\244\244\244\345')

  [ FAIL 4 | WARN 0 | SKIP 16 | PASS 670 ]
  Error: Test failures
  In addition: Warning message:
  call dbDisconnect() when finished working with a connection
  Execution halted
* DONE

Any thoughts so we can preceed?

Investigating test failures that occurs on 2.3.5 and 2.3.6
https://github.com/r-dbi/RSQLite/issues/502

Nice, tests are fixed and it gives me more confidence that R pkg works fine.

I will upload 2.3.6 update patch soon.

Can't update diff on this review, please see update to 2.3.6 instead:
https://reviews.freebsd.org/D44592

Thanks