Differential D44384

tcp: no data on SYN unless doing TFO
ClosedPublic
Actions

Authored by tuexen on Mar 15 2024, 10:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 10, 4:59 PM

	Unknown Object (File)
	Sun, Feb 9, 12:03 AM

	Unknown Object (File)
	Fri, Jan 24, 9:28 PM

	Unknown Object (File)
	Fri, Jan 24, 8:57 PM

	Unknown Object (File)
	Jan 9 2025, 9:30 PM

	Unknown Object (File)
	Jan 9 2025, 11:29 AM

	Unknown Object (File)
	Jan 4 2025, 12:06 AM

	Unknown Object (File)
	Dec 11 2024, 8:42 PM

View All 98 Files

Subscribers

Details

Reviewers

glebius
rscheff
rrs

Group Reviewers

Commits

rG2290185085ee: tcp: no data on SYN segments unless doing TFO
rGfd2a580db248: tcp: no data on SYN segments unless doing TFO
rGaf700f430fd8: tcp: no data on SYN segments unless doing TFO

Summary

Ensure that there is no data on SYN segments unless doing TFO. This check is already in RACK and BBR.

Test Plan

Ensure the following script passes:

+0.000 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+0.000 sendto(3, ..., 100, 0, ..., ...) = 100
+0.000 > S    0:0(0)             win 65535 <mss 1460,nop,wscale 6, sackOK, TS val 1000 ecr 0>
+0.050 < S.   0:0(0)     ack   1 win 65535 <mss 1460>
+0.000 > P.   1:101(100) ack   1 win 65535
+0.050 <  .   1:1(0)     ack 101 win 65535
+0.000 close(3) = 0
+0.000 > F. 101:101(0)   ack   1 win 65535
+0.050 < F.   1:1(0)     ack 102 win 65535
+0.000 >  . 102:102(0)   ack   2 win 65535

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Mar 15 2024, 10:46 PM

Herald added a reviewer: transport. · View Herald TranscriptMar 15 2024, 10:46 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Mar 15 2024, 10:46 PM

Rebase to main.

rscheff accepted this revision.Mar 21 2024, 3:12 PM

This revision is now accepted and ready to land.Mar 21 2024, 3:12 PM

Closed by commit rGaf700f430fd8: tcp: no data on SYN segments unless doing TFO (authored by tuexen). · Explain WhyMar 22 2024, 10:19 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGaf700f430fd8: tcp: no data on SYN segments unless doing TFO.

tuexen added a commit: rGfd2a580db248: tcp: no data on SYN segments unless doing TFO.Apr 17 2024, 1:50 PM

tuexen added a commit: rG2290185085ee: tcp: no data on SYN segments unless doing TFO.Aug 1 2024, 8:25 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

6 lines

Diff 135896

sys/netinet/tcp_output.c

Loading...