Differential D44356

freebsd-update: mark "cron" as fetched as "fetch" itself
ClosedPublic
Actions

Authored by michaelo on Mar 14 2024, 4:49 PM.

Tags

None

Referenced Files

	F167959388: D44356.id135753.diff
	Tue, Aug 25, 3:29 PM

	F167896970: D44356.id.diff
	Tue, Aug 25, 7:57 AM

	Unknown Object (File)
	Tue, Aug 25, 7:12 AM

	Unknown Object (File)
	Sun, Aug 23, 1:32 PM

	Unknown Object (File)
	Fri, Aug 14, 7:39 PM

	Unknown Object (File)
	Fri, Aug 14, 7:35 PM

	Unknown Object (File)
	Thu, Aug 13, 1:24 PM

	Unknown Object (File)
	Wed, Aug 12, 3:23 PM

Subscribers

Details

Reviewers

jrm
otis
cperciva
emaste

Commits

rGfc5208028a78: freebsd-update: mark "cron" as fetched as "fetch" itself
rGe54b9d17f82d: freebsd-update: mark "cron" as fetched as "fetch" itself
rG85c3ef77cc9f: freebsd-update: mark "cron" as fetched as "fetch" itself

Summary

The change in 33bd05c3187d7b49c80cf1b0132b405c105d0833 was incomplete
because it did not mark "cron" as ISFETCHED=1 although it performs the
same operations as "install", but less output and does not perform a
hard exit. Mark result as such and make "install" know that updates have
been fetched.

PR: 277699
Approved by: jrm (mentor), otis (mentor)
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michaelo created this revision.Mar 14 2024, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 14 2024, 4:49 PM

michaelo requested review of this revision.Mar 14 2024, 4:49 PM

Harbormaster completed remote builds in B56602: Diff 135753.Mar 14 2024, 4:49 PM

@cperciva, it would be good to get your approval here as well.

This revision is now accepted and ready to land.Mar 15 2024, 3:47 PM

In D44356#1011926, @jrm wrote:

@cperciva, it would be good to get your approval here as well.

Unless someone says that one should never do "cron install" in one go in a cronjob...

Fine with me. Installing updates from cron isn't particularly recommended, but there may be cases where it is appropriate.

emaste accepted this revision.Mar 17 2024, 3:04 PM

Closed by commit rG85c3ef77cc9f: freebsd-update: mark "cron" as fetched as "fetch" itself (authored by michaelo). · Explain WhyMar 18 2024, 10:03 AM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: rG85c3ef77cc9f: freebsd-update: mark "cron" as fetched as "fetch" itself.

michaelo added a commit: rGe54b9d17f82d: freebsd-update: mark "cron" as fetched as "fetch" itself.Apr 1 2024, 7:19 PM

michaelo added a commit: rGfc5208028a78: freebsd-update: mark "cron" as fetched as "fetch" itself.

Revision Contents
Changeset List

Path

Size

usr.sbin/

freebsd-update/

freebsd-update.sh

1 line

Diff 135867

usr.sbin/freebsd-update/freebsd-update.sh

Loading...