pmc: Fix some problems with the makefile
ClosedPublic
Actions

Authored by markj on Feb 15 2024, 6:26 PM.

Tags

None

Referenced Files

	F171411458: D43923.id134448.diff
	Thu, Sep 10, 11:52 PM

	F171364409: D43923.id134389.diff
	Thu, Sep 10, 5:01 PM

	F171352730: D43923.diff
	Thu, Sep 10, 3:15 PM

	Unknown Object (File)
	Sat, Sep 5, 5:25 PM

	Unknown Object (File)
	Sat, Sep 5, 4:42 PM

	Unknown Object (File)
	Sat, Sep 5, 4:42 PM

	Unknown Object (File)
	Sat, Sep 5, 3:26 PM

	Unknown Object (File)
	Sat, Sep 5, 10:26 AM

View All Files

Subscribers

imp

Details

Reviewers

brooks
emaste
imp

Commits

rG23d4d0fcc1be: pmc: Fix some problems with the makefile

Summary

For some reason we don't build it as a PIE, but I don't have any problems doing so with either clang or gcc.
There is no apparent need to override WARNS, so don't.
Some building with -O0, presumably that's left over from debugging.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56048
Build 52937: arc lint + arc unit

Event Timeline

markj created this revision.Feb 15 2024, 6:26 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 15 2024, 6:26 PM

markj requested review of this revision.Feb 15 2024, 6:26 PM

Harbormaster completed remote builds in B56048: Diff 134389.Feb 15 2024, 6:26 PM

Seems reasonable if it's working now.

This revision is now accepted and ready to land.Feb 15 2024, 11:20 PM

imp accepted this revision.Feb 15 2024, 11:23 PM

Closed by commit rG23d4d0fcc1be: pmc: Fix some problems with the makefile (authored by markj). · Explain WhyFeb 16 2024, 2:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG23d4d0fcc1be: pmc: Fix some problems with the makefile.

Revision Contents
Changeset List

Path

Size

usr.sbin/

pmc/

Makefile

9 lines

Diff 134389

View Options

pmc: Fix some problems with the makefileClosedPublicActions