Page MenuHomeFreeBSD

reboot: Use posix_spawn instead of system
ClosedPublic

Authored by imp on Feb 13 2024, 4:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 9:49 AM
Unknown Object (File)
Mar 3 2025, 3:43 PM
Unknown Object (File)
Feb 12 2025, 11:15 PM
Unknown Object (File)
Feb 12 2025, 11:27 AM
Unknown Object (File)
Feb 9 2025, 8:15 AM
Unknown Object (File)
Feb 7 2025, 11:24 PM
Unknown Object (File)
Feb 5 2025, 7:19 PM
Unknown Object (File)
Feb 5 2025, 5:00 PM
Subscribers

Details

Summary

Use posix_spawn to avoid having to allocate memory needed for the system
command line.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55980
Build 52869: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 13 2024, 4:50 AM
imp created this revision.
sbin/reboot/reboot.c
76

Shouldn't there only be one copy?

95

Check return value? Especially for EINTR.

105–107

Would seem more natural to flip these two cases?

sbin/reboot/reboot.c
76

Oh, yes.

95

Should we look on EINTR? Or just ignore it?

105–107

sure.

This revision is now accepted and ready to land.Feb 15 2024, 11:17 PM
This revision was automatically updated to reflect the committed changes.