Page MenuHomeFreeBSD
Differential D40350

setusercontext(): Move priority setting in new setclasspriority()
ClosedPublic
Actions

Authored by olce on May 31 2023, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 7:57 PM
Unknown Object (File)
Feb 8 2025, 7:36 AM
Unknown Object (File)
Feb 1 2025, 10:33 AM
Unknown Object (File)
Jan 21 2025, 3:49 PM
Unknown Object (File)
Jan 21 2025, 3:42 PM
Unknown Object (File)
Jan 6 2025, 7:35 PM
Unknown Object (File)
Jan 4 2025, 8:42 PM
Unknown Object (File)
Dec 19 2024, 9:18 PM
View All Files
Subscribers
andrew_tao173.riddles.org.uk
imp

Details

Reviewers
kib
mjg
yuripv
kevans
des
emaste
Commits
rGf49953dd49f2: setusercontext(): Move priority setting in new setclasspriority()
rG3fc149c302ab: setusercontext(): Move priority setting in new setclasspriority()
rG7b94ec550ef6: setusercontext(): Move priority setting in new setclasspriority()
Summary

In preparation for setting priorities from '.login_conf' and to ease reading of
setusercontext().

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55624
Build 52513: arc lint + arc unit

Event Timeline

olce created this revision.May 31 2023, 3:18 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2023, 3:18 PM
olce requested review of this revision.May 31 2023, 3:18 PM
Harbormaster completed remote builds in B51804: Diff 122659.May 31 2023, 3:18 PM
olce added a parent revision: D40349: setusercontext(): Better error messages when priority is not set correctly.May 31 2023, 3:19 PM
olce added a child revision: D40351: setusercontext(): Apply user login context only on process' euid being set.
olce added reviewers: kib, mjg, yuripv, kevans, des.Jun 6 2023, 8:28 AM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptJun 6 2023, 8:28 AM
olce updated this revision to Diff 123601.Jun 21 2023, 1:52 PM

Refresh

Harbormaster completed remote builds in B52224: Diff 123601.Jun 21 2023, 1:52 PM
olce added a parent revision: D40689: login.conf(5): Document priority's default and possible values.Jun 21 2023, 1:53 PM
olce removed a parent revision: D40349: setusercontext(): Better error messages when priority is not set correctly.
olce added a child revision: D40690: setclasspriority(): New value 'inherit'.Jun 21 2023, 1:55 PM
olce removed a child revision: D40351: setusercontext(): Apply user login context only on process' euid being set.Jun 21 2023, 1:58 PM
olce updated this revision to Diff 133374.Jan 25 2024, 10:45 PM

Refresh

Harbormaster completed remote builds in B55624: Diff 133374.Jan 25 2024, 10:45 PM
emaste accepted this revision.Jan 29 2024, 1:51 PM
This revision is now accepted and ready to land.Jan 29 2024, 1:51 PM
Closed by commit rG7b94ec550ef6: setusercontext(): Move priority setting in new setclasspriority() (authored by olce). · Explain WhyJan 29 2024, 10:32 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG7b94ec550ef6: setusercontext(): Move priority setting in new setclasspriority().
olce added a commit: rG3fc149c302ab: setusercontext(): Move priority setting in new setclasspriority().Feb 1 2024, 9:26 PM
olce added a commit: rGf49953dd49f2: setusercontext(): Move priority setting in new setclasspriority().Feb 1 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
97 lines

Diff 133374

View Options

lib/libutil/login_class.c

Show First 20 Lines • Show All 105 Lines • ▼ Show 20 Lines
/* /*
* Raw CP15 maintenance operations * Raw CP15 maintenance operations
* !!! not for external use !!! * !!! not for external use !!!
*/ */
/* TLB */ /* TLB */
_WF0(_CP15_TLBIALL, CP15_TLBIALL) /* Invalidate entire unified TLB */ _WF0(_CP15_TLBIALL, CP15_TLBIALL) /* Invalidate entire unified TLB */
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
_WF0(_CP15_TLBIALLIS, CP15_TLBIALLIS) /* Invalidate entire unified TLB IS */ _WF0(_CP15_TLBIALLIS, CP15_TLBIALLIS) /* Invalidate entire unified TLB IS */
#endif #endif
_WF1(_CP15_TLBIASID, CP15_TLBIASID(%0)) /* Invalidate unified TLB by ASID */ _WF1(_CP15_TLBIASID, CP15_TLBIASID(%0)) /* Invalidate unified TLB by ASID */
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
_WF1(_CP15_TLBIASIDIS, CP15_TLBIASIDIS(%0)) /* Invalidate unified TLB by ASID IS */ _WF1(_CP15_TLBIASIDIS, CP15_TLBIASIDIS(%0)) /* Invalidate unified TLB by ASID IS */
#endif #endif
_WF1(_CP15_TLBIMVAA, CP15_TLBIMVAA(%0)) /* Invalidate unified TLB by MVA, all ASID */ _WF1(_CP15_TLBIMVAA, CP15_TLBIMVAA(%0)) /* Invalidate unified TLB by MVA, all ASID */
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
_WF1(_CP15_TLBIMVAAIS, CP15_TLBIMVAAIS(%0)) /* Invalidate unified TLB by MVA, all ASID IS */ _WF1(_CP15_TLBIMVAAIS, CP15_TLBIMVAAIS(%0)) /* Invalidate unified TLB by MVA, all ASID IS */
#endif #endif
_WF1(_CP15_TLBIMVA, CP15_TLBIMVA(%0)) /* Invalidate unified TLB by MVA */ _WF1(_CP15_TLBIMVA, CP15_TLBIMVA(%0)) /* Invalidate unified TLB by MVA */
_WF1(_CP15_TTB_SET, CP15_TTBR0(%0)) _WF1(_CP15_TTB_SET, CP15_TTBR0(%0))
/* Cache and Branch predictor */ /* Cache and Branch predictor */
_WF0(_CP15_BPIALL, CP15_BPIALL) /* Branch predictor invalidate all */ _WF0(_CP15_BPIALL, CP15_BPIALL) /* Branch predictor invalidate all */
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
_WF0(_CP15_BPIALLIS, CP15_BPIALLIS) /* Branch predictor invalidate all IS */ _WF0(_CP15_BPIALLIS, CP15_BPIALLIS) /* Branch predictor invalidate all IS */
#endif #endif
_WF1(_CP15_BPIMVA, CP15_BPIMVA(%0)) /* Branch predictor invalidate by MVA */ _WF1(_CP15_BPIMVA, CP15_BPIMVA(%0)) /* Branch predictor invalidate by MVA */
_WF1(_CP15_DCCIMVAC, CP15_DCCIMVAC(%0)) /* Data cache clean and invalidate by MVA PoC */ _WF1(_CP15_DCCIMVAC, CP15_DCCIMVAC(%0)) /* Data cache clean and invalidate by MVA PoC */
_WF1(_CP15_DCCISW, CP15_DCCISW(%0)) /* Data cache clean and invalidate by set/way */ _WF1(_CP15_DCCISW, CP15_DCCISW(%0)) /* Data cache clean and invalidate by set/way */
_WF1(_CP15_DCCMVAC, CP15_DCCMVAC(%0)) /* Data cache clean by MVA PoC */ _WF1(_CP15_DCCMVAC, CP15_DCCMVAC(%0)) /* Data cache clean by MVA PoC */
#if __ARM_ARCH >= 7 #if __ARM_ARCH >= 7
_WF1(_CP15_DCCMVAU, CP15_DCCMVAU(%0)) /* Data cache clean by MVA PoU */ _WF1(_CP15_DCCMVAU, CP15_DCCMVAU(%0)) /* Data cache clean by MVA PoU */
#endif #endif
_WF1(_CP15_DCCSW, CP15_DCCSW(%0)) /* Data cache clean by set/way */ _WF1(_CP15_DCCSW, CP15_DCCSW(%0)) /* Data cache clean by set/way */
_WF1(_CP15_DCIMVAC, CP15_DCIMVAC(%0)) /* Data cache invalidate by MVA PoC */ _WF1(_CP15_DCIMVAC, CP15_DCIMVAC(%0)) /* Data cache invalidate by MVA PoC */
_WF1(_CP15_DCISW, CP15_DCISW(%0)) /* Data cache invalidate by set/way */ _WF1(_CP15_DCISW, CP15_DCISW(%0)) /* Data cache invalidate by set/way */
_WF0(_CP15_ICIALLU, CP15_ICIALLU) /* Instruction cache invalidate all PoU */ _WF0(_CP15_ICIALLU, CP15_ICIALLU) /* Instruction cache invalidate all PoU */
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
_WF0(_CP15_ICIALLUIS, CP15_ICIALLUIS) /* Instruction cache invalidate all PoU IS */ _WF0(_CP15_ICIALLUIS, CP15_ICIALLUIS) /* Instruction cache invalidate all PoU IS */
#endif #endif
_WF1(_CP15_ICIMVAU, CP15_ICIMVAU(%0)) /* Instruction cache invalidate */ _WF1(_CP15_ICIMVAU, CP15_ICIMVAU(%0)) /* Instruction cache invalidate */
/* /*
* Publicly accessible functions * Publicly accessible functions
*/ */
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Linestlb_flush_range_local(vm_offset_t va, vm_size_t size)
dsb(); dsb();
for (; va < eva; va += PAGE_SIZE) for (; va < eva; va += PAGE_SIZE)
_CP15_TLBIMVA(va | CPU_ASID_KERNEL); _CP15_TLBIMVA(va | CPU_ASID_KERNEL);
dsb(); dsb();
} }
/* Broadcasting operations. */ /* Broadcasting operations. */
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
#if defined(CPU_CORTEXA8) #if defined(CPU_CORTEXA8) && \
(defined(CPU_CORTEXA_MP) || defined(CPU_KRAIT) || defined(CPU_MV_PJ4B))
#define ARM_HAVE_MP_EXTENSIONS (cpuinfo.mp_ext != 0) #define ARM_HAVE_MP_EXTENSIONS (cpuinfo.mp_ext != 0)
#elif defined(CPU_CORTEXA8)
#define ARM_HAVE_MP_EXTENSIONS 0
#else #else
#define ARM_HAVE_MP_EXTENSIONS 1 #define ARM_HAVE_MP_EXTENSIONS 1
#endif #endif
static __inline void static __inline void
tlb_flush_all(void) tlb_flush_all(void)
{ {
▲ Show 20 Lines • Show All 45 Lines • ▼ Show 20 Lines if (ARM_HAVE_MP_EXTENSIONS) {
for (; va < eva; va += PAGE_SIZE) for (; va < eva; va += PAGE_SIZE)
_CP15_TLBIMVAAIS(va); _CP15_TLBIMVAAIS(va);
} else { } else {
for (; va < eva; va += PAGE_SIZE) for (; va < eva; va += PAGE_SIZE)
_CP15_TLBIMVA(va | CPU_ASID_KERNEL); _CP15_TLBIMVA(va | CPU_ASID_KERNEL);
} }
dsb(); dsb();
} }
#else /* SMP */ #else /* __ARM_ARCH < 7 */
#define tlb_flush_all() tlb_flush_all_local() #define tlb_flush_all() tlb_flush_all_local()
#define tlb_flush_all_ng() tlb_flush_all_ng_local() #define tlb_flush_all_ng() tlb_flush_all_ng_local()
#define tlb_flush(va) tlb_flush_local(va) #define tlb_flush(va) tlb_flush_local(va)
#define tlb_flush_range(va, size) tlb_flush_range_local(va, size) #define tlb_flush_range(va, size) tlb_flush_range_local(va, size)
#endif /* SMP */ #endif /* __ARM_ARCH < 7 */
/* /*
* Cache maintenance operations. * Cache maintenance operations.
*/ */
/* Sync I and D caches to PoU */ /* Sync I and D caches to PoU */
static __inline void static __inline void
icache_sync(vm_offset_t va, vm_size_t size) icache_sync(vm_offset_t va, vm_size_t size)
{ {
vm_offset_t eva = va + size; vm_offset_t eva = va + size;
dsb(); dsb();
va &= ~cpuinfo.dcache_line_mask; va &= ~cpuinfo.dcache_line_mask;
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
if (ARM_HAVE_MP_EXTENSIONS) { if (ARM_HAVE_MP_EXTENSIONS) {
for ( ; va < eva; va += cpuinfo.dcache_line_size) for ( ; va < eva; va += cpuinfo.dcache_line_size)
_CP15_DCCMVAU(va); _CP15_DCCMVAU(va);
} else } else
#endif #endif
{ {
for ( ; va < eva; va += cpuinfo.dcache_line_size) for ( ; va < eva; va += cpuinfo.dcache_line_size)
_CP15_DCCMVAC(va); _CP15_DCCMVAC(va);
} }
dsb(); dsb();
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
if (ARM_HAVE_MP_EXTENSIONS) if (ARM_HAVE_MP_EXTENSIONS)
_CP15_ICIALLUIS(); _CP15_ICIALLUIS();
else else
#endif #endif
_CP15_ICIALLU(); _CP15_ICIALLU();
dsb(); dsb();
isb(); isb();
} }
/* Invalidate I cache */ /* Invalidate I cache */
static __inline void static __inline void
icache_inv_all(void) icache_inv_all(void)
{ {
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
if (ARM_HAVE_MP_EXTENSIONS) if (ARM_HAVE_MP_EXTENSIONS)
_CP15_ICIALLUIS(); _CP15_ICIALLUIS();
else else
#endif #endif
_CP15_ICIALLU(); _CP15_ICIALLU();
dsb(); dsb();
isb(); isb();
} }
/* Invalidate branch predictor buffer */ /* Invalidate branch predictor buffer */
static __inline void static __inline void
bpb_inv_all(void) bpb_inv_all(void)
{ {
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
if (ARM_HAVE_MP_EXTENSIONS) if (ARM_HAVE_MP_EXTENSIONS)
_CP15_BPIALLIS(); _CP15_BPIALLIS();
else else
#endif #endif
_CP15_BPIALL(); _CP15_BPIALL();
dsb(); dsb();
isb(); isb();
} }
/* Write back D-cache to PoU */ /* Write back D-cache to PoU */
static __inline void static __inline void
dcache_wb_pou(vm_offset_t va, vm_size_t size) dcache_wb_pou(vm_offset_t va, vm_size_t size)
{ {
vm_offset_t eva = va + size; vm_offset_t eva = va + size;
dsb(); dsb();
va &= ~cpuinfo.dcache_line_mask; va &= ~cpuinfo.dcache_line_mask;
#if __ARM_ARCH >= 7 && defined SMP #if __ARM_ARCH >= 7
if (ARM_HAVE_MP_EXTENSIONS) { if (ARM_HAVE_MP_EXTENSIONS) {
for ( ; va < eva; va += cpuinfo.dcache_line_size) for ( ; va < eva; va += cpuinfo.dcache_line_size)
_CP15_DCCMVAU(va); _CP15_DCCMVAU(va);
} else } else
#endif #endif
{ {
for ( ; va < eva; va += cpuinfo.dcache_line_size) for ( ; va < eva; va += cpuinfo.dcache_line_size)
_CP15_DCCMVAC(va); _CP15_DCCMVAC(va);
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines