Page MenuHomeFreeBSD
Differential D43560

tcp: improve tcp_ecn by using switch statements and bit-shifting
ClosedPublic
Actions

Authored by rscheff on Jan 23 2024, 2:49 PM.
Tags
None
Referenced Files
F103119300: D43560.diff
Thu, Nov 21, 6:43 AM
Unknown Object (File)
Thu, Nov 7, 1:14 PM
Unknown Object (File)
Thu, Nov 7, 10:10 AM
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Tue, Oct 22, 4:57 PM
Unknown Object (File)
Oct 20 2024, 2:58 AM
View All 41 Files
Subscribers
imp
melifaro

Details

Reviewers
cc
glebius
tuexen
thj
rrs
Group Reviewers
transport
Commits
rGfc262fd3dc0a: tcp: AccECN access ACE field by shifting bits
Summary

In order to improve readability, use switch statements to
differentiate between the different ECN signallings.

Also, access the ACE field by bit-shifting instead checking
each flag individually.

No change in behaviour.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55575
Build 52464: arc lint + arc unit

Event Timeline

rscheff created this revision.Jan 23 2024, 2:49 PM
Herald added a reviewer: transport. · View Herald TranscriptJan 23 2024, 2:49 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Jan 23 2024, 2:49 PM
Harbormaster completed remote builds in B55569: Diff 133197.Jan 23 2024, 2:49 PM
glebius added a comment.Jan 23 2024, 6:36 PM

P.S. There are so many sysctl toggles that ask for SYSCTL_INT_MINMAX() macro, to avoid coding out yet another value checking function but to block user from entering invalid value.

sys/netinet/tcp_ecn.c
103

AFAIK, these should be one liners per style(9).

123

Not sure it is documented, but usual habit is to leave default: as the last case.

glebius accepted this revision.Jan 23 2024, 6:36 PM
rscheff updated this revision to Diff 133228.Jan 23 2024, 7:17 PM
  • remove default case, as falling through and returning is the correct action.
Harbormaster completed remote builds in B55575: Diff 133228.Jan 23 2024, 7:18 PM
tuexen added inline comments.Jan 24 2024, 7:17 AM
sys/netinet/tcp_ecn.c
226

The indentation looks strange here...

rscheff updated this revision to Diff 133284.Jan 24 2024, 4:26 PM
rscheff marked an inline comment as done.
  • remove default: when no special action is necessary
  • place statemens after case: in new line
  • add /* FALLTHROUGH */ comments per style(9)
Harbormaster completed remote builds in B55594: Diff 133284.Jan 24 2024, 4:26 PM
rscheff marked an inline comment as done.Jan 24 2024, 4:27 PM
tuexen accepted this revision.Jan 25 2024, 8:28 PM
This revision is now accepted and ready to land.Jan 25 2024, 8:28 PM
Closed by commit rGfc262fd3dc0a: tcp: AccECN access ACE field by shifting bits (authored by rscheff). · Explain WhyJan 25 2024, 11:19 PM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rGfc262fd3dc0a: tcp: AccECN access ACE field by shifting bits.

Revision Contents
Changeset List

PathSize
sys/
netinet/
3 lines
67 lines

Diff 133228

View Options

sys/netinet/tcp_ecn.h

Loading...
View Options

sys/netinet/tcp_ecn.c

Loading...