Page MenuHomeFreeBSD
Differential D43346

tcp: missed the use of enum to check sack_changed
ClosedPublic
Actions

Authored by rscheff on Jan 6 2024, 4:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 2:19 PM
Unknown Object (File)
Sat, Apr 12, 6:50 AM
Unknown Object (File)
Sun, Apr 6, 5:50 AM
Unknown Object (File)
Sun, Mar 23, 5:28 PM
Unknown Object (File)
Mar 15 2025, 8:17 AM
Unknown Object (File)
Feb 22 2025, 2:37 PM
Unknown Object (File)
Feb 22 2025, 1:53 PM
Unknown Object (File)
Feb 22 2025, 1:51 PM
View All 36 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
tuexen
cc
Group Reviewers
transport
Commits
rG541d89067add: tcp: Make use of enum for sack_changed
rG893ed42eca32: tcp: Make use of enum for sack_changed
Summary

In D28822, the return value when a SACK containing ACK
is received was converted to an enum. Missed one instance
where this is checked against.

No functional change.

MFC after: 3 day.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55273
Build 52162: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netinet/
3 lines

Diff 132372

View Options

sys/netinet/tcp_input.c

Show First 20 Lines • Show All 4,327 Lines • ▼ Show 20 Lines for dir in $$(${ALL-DEPENDS-LIST}); do \
_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \ _p=$$(cd $$dir; ${MAKE} -VPKGNAME); \
if ! $$(${ECHO_CMD} $${_packages} | ${GREP} -q $${_p}); then \ if ! $$(${ECHO_CMD} $${_packages} | ${GREP} -q $${_p}); then \
${ECHO_CMD} $${_p}; \ ${ECHO_CMD} $${_p}; \
fi; \ fi; \
done done
# Install missing dependencies from package # Install missing dependencies from package
install-missing-packages: install-missing-packages:
@_dirs=$$(${MISSING-DEPENDS-LIST}); \ @_dirs=$$(${MISSING-DEPENDS-LIST}); \
if [ -n "$${_dirs}" ]; then \ ${ECHO_CMD} "$${_dirs}" | ${SED} "s%${PORTSDIR}/%%g" | ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A"
matUnsubmitted
Done
Inline Actions

I would use | ${XARGS} which will take care of that.

mat: I would use `| ${XARGS}` which will take care of that.
0mpAuthorUnsubmitted
Done
Inline Actions

Hmm, sure, although I think that tr is more explicit.

0mp: Hmm, sure, although I think that tr is more explicit.
tobikUnsubmitted
Done
Inline Actions

This should be

${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" | ${SED} 's%${PORTSDIR}/%%g' | ${XARGS} ${PKG_BIN} install -A"

or even better push the su outwards as much as possible

${ECHO_CMD} "$${_dirs}" | ${SED} "s%${PORTSDIR}/%%g" | ${SU_CMD} "${XARGS} ${PKG_BIN} install -A"

tobik: This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" | ${SED} 's%${PORTSDIR}/%%g' | ${XARGS}…
0mpAuthorUnsubmitted
Done
Inline Actions

We've tried that approach, @tobik.

The problem is that then you cannot have interactive prompts from pkg (stdin is taken by xargs).

0mp: We've tried that approach, @tobik. The problem is that then you cannot have interactive…
tobikUnsubmitted
Done
Inline Actions

I see. Luckily there seems to be an xargs(1) flag for exactly that, -o:

${ECHO_CMD} "$${_dirs}" | ${SED} "s%${PORTSDIR}/%%g" | ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A"
tobik: I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ``` ${ECHO_CMD}…
0mpAuthorUnsubmitted
Done
Inline Actions

Ha! I didn't know about this one! Thanks.

0mp: Ha! I didn't know about this one! Thanks.
${SU_CMD} "${PKG_BIN} install -A $$(${ECHO_CMD} "$${_dirs}" | ${SED} "s%${PORTSDIR}/%%g")"; \
fi
################################################################ ################################################################
# Everything after here are internal targets and really # Everything after here are internal targets and really
# shouldn't be touched by anybody but the release engineers. # shouldn't be touched by anybody but the release engineers.
################################################################ ################################################################
# This target generates an index entry suitable for aggregation into # This target generates an index entry suitable for aggregation into
# a large index. Format is: # a large index. Format is:
▲ Show 20 Lines • Show All 1,058 Lines • Show Last 20 Lines