Differential D42709

memfd_create: move implementation to libc/gen
ClosedPublic
Actions

Authored by brooks on Nov 22 2023, 1:08 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 25, 6:15 AM

	Unknown Object (File)
	Sun, Mar 22, 3:06 AM

	Unknown Object (File)
	Sat, Mar 21, 6:51 AM

	Unknown Object (File)
	Fri, Mar 20, 5:21 PM

	Unknown Object (File)
	Thu, Mar 5, 4:19 AM

	Unknown Object (File)
	Feb 14 2026, 6:28 PM

	Unknown Object (File)
	Nov 26 2025, 4:56 PM

	Unknown Object (File)
	Nov 26 2025, 11:44 AM

Subscribers

None

Details

Reviewers

imp
emaste
kevans

Commits

rG89ebe0ce1f53: memfd_create: move implementation to libc/gen
rGc3207e2d2554: memfd_create: move implementation to libc/gen

Summary

Due to memfd_create(3)'s construction of a path to pass to shm_open2(2),
it has a much larger than typical dependency footprint for a system
call wrapper (the list currently includes calloc, memset, sprintf, and
strlen). As such, split it off into it's own file under libc/gen
to lighten libc/sys's dependency list.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54557
Build 51446: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Nov 22 2023, 1:08 AM

brooks created this revision.

brooks added a parent revision: D42708: getpagesize(3): drop support for non-ELF kernels.

Harbormaster completed remote builds in B54557: Diff 130412.Nov 22 2023, 1:08 AM

brooks added a child revision: D42710: memfd_create: don't allocate heap memory.Nov 22 2023, 1:09 AM

Saw on github. Looks goud

This revision is now accepted and ready to land.Nov 22 2023, 1:45 AM

emaste accepted this revision.Nov 22 2023, 1:56 AM

emaste added inline comments.

lib/libc/gen/memfd_create.c
31–41	are any of these headers no longer needed in one or the other of these files?

No objection, lgtm

tidy headers

This revision now requires review to proceed.Nov 22 2023, 8:32 PM

Harbormaster completed remote builds in B54580: Diff 130446.Nov 22 2023, 8:32 PM

emaste accepted this revision.Nov 23 2023, 12:51 AM

This revision is now accepted and ready to land.Nov 23 2023, 12:51 AM

Closed by commit rGc3207e2d2554: memfd_create: move implementation to libc/gen (authored by brooks). · Explain WhyNov 28 2023, 5:16 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGc3207e2d2554: memfd_create: move implementation to libc/gen.

brooks added a commit: rG89ebe0ce1f53: memfd_create: move implementation to libc/gen.Dec 21 2023, 6:17 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

1 line

1 line

	gen/
	sys/

	memfd_create.c
	shm_open.c

34 lines

sys/

1 line

90 lines

Diff 130412

lib/libc/gen/Makefile.inc

Loading...

lib/libc/gen/Symbol.map

Loading...

lib/libc/gen/memfd_create.c

Loading...

lib/libc/sys/Symbol.map

Loading...

lib/libc/sys/shm_open.c

Loading...