Page MenuHomeFreeBSD
Differential D42708

getpagesize(3): drop support for non-ELF kernels
ClosedPublic
Actions

Authored by brooks on Nov 22 2023, 1:08 AM.
Tags
None
Referenced Files
F83280154: D42708.id.diff
Wed, May 8, 9:20 AM
F83280133: D42708.id130654.diff
Wed, May 8, 9:20 AM
F83273247: D42708.id130411.diff
Wed, May 8, 6:49 AM
F83273221: D42708.id130445.diff
Wed, May 8, 6:49 AM
Unknown Object (File)
Thu, Apr 25, 1:42 AM
Unknown Object (File)
Thu, Apr 25, 1:42 AM
Unknown Object (File)
Thu, Apr 25, 1:42 AM
Unknown Object (File)
Thu, Apr 25, 1:41 AM
View All 19 Files
Subscribers
None

Details

Reviewers
imp
emaste
kevans
Commits
rGea180bb3797e: getpagesize(3): drop support for non-ELF kernels
Summary

AT_PAGESZ was introduced with ELF support in 1996 (commit
e1743d02cd14069f69a50bb8a6c626c1c6f47ddd) so we can safely count on
being able to use it to get our page size via elf_aux_info(). As such
we don't need a fallback sysctl query.

Save a few bytes of bss by dropping caching as elf_aux_info() runs
in constant time for a given query.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Nov 22 2023, 1:08 AM
brooks created this revision.
Harbormaster completed remote builds in B54556: Diff 130411.Nov 22 2023, 1:08 AM
brooks added a parent revision: D42707: getpagesizes(3): drop support for kernels before 9.0.Nov 22 2023, 1:08 AM
brooks added a child revision: D42709: memfd_create: move implementation to libc/gen.
emaste accepted this revision.Nov 22 2023, 1:23 AM
emaste added inline comments.
lib/libc/gen/getpagesize.c
44–47

maybe simplify by dropping error and just if (_elf_aux_info(AT_PAGESZ, &value, sizeof(value) != 0)...

This revision is now accepted and ready to land.Nov 22 2023, 1:23 AM
imp accepted this revision.Nov 22 2023, 1:47 AM
kevans accepted this revision.Nov 22 2023, 5:45 AM
brooks updated this revision to Diff 130445.Nov 22 2023, 8:32 PM
  • drop error variable
This revision now requires review to proceed.Nov 22 2023, 8:32 PM
Harbormaster completed remote builds in B54579: Diff 130445.Nov 22 2023, 8:32 PM
emaste accepted this revision.Nov 22 2023, 9:44 PM
This revision is now accepted and ready to land.Nov 22 2023, 9:44 PM
Closed by commit rGea180bb3797e: getpagesize(3): drop support for non-ELF kernels (authored by brooks). · Explain WhyNov 28 2023, 5:16 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGea180bb3797e: getpagesize(3): drop support for non-ELF kernels.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
28 lines

Diff 130654

View Options

lib/libc/gen/getpagesize.c

Loading...