Page MenuHomeFreeBSD
Differential D39013

arm: Introduce MK_KERNEL_BIN to control generation of kernel.bin
ClosedPublic
Actions

Authored by imp on Mar 10 2023, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 5:08 PM
Unknown Object (File)
Thu, Nov 28, 5:07 PM
Unknown Object (File)
Thu, Nov 28, 5:07 PM
Unknown Object (File)
Thu, Nov 28, 5:07 PM
Unknown Object (File)
Thu, Nov 28, 5:07 PM
Unknown Object (File)
Thu, Nov 28, 5:06 PM
Unknown Object (File)
Thu, Nov 28, 5:06 PM
Unknown Object (File)
Thu, Nov 28, 5:06 PM
View All Files
Subscribers
andrew
emaste

Details

Reviewers
manu
mw
mmel
andrew
Commits
rG34632ed1a495: arm: Introduce MK_KERNEL_BIN to control generation of kernel.bin
Summary

It's sometimes desirable to generate kernel.bin and install it. While
the mainstream has moved on to UEFI booting on arm, some specialized
gear can't support it. For that gear, we unconditionally generate
kernel.bin. Add a knob so that WITH_KERNEL_BIN or WITHOUT_KERNEL_BIN
control its generation and installation. config files should add
'makeoptions WITH_KERNEL_BIN=t' to enable it. Since its use is
specialized, it is off by default now since the arm world has largely
moved on to UEFI.

It only affects arm and arm64 (since those are the only two that support
it).

Sponsored by: Netflix

Test Plan

Note: needs docs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Mar 10 2023, 12:33 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptMar 10 2023, 12:33 PM
imp requested review of this revision.Mar 10 2023, 12:33 PM
Harbormaster completed remote builds in B50269: Diff 118614.Mar 10 2023, 12:33 PM
imp edited the test plan for this revision. (Show Details)Mar 10 2023, 12:34 PM
imp added reviewers: manu, mw.
manu added inline comments.Mar 10 2023, 12:38 PM
sys/conf/kern.opts.mk
89

s/KERNEL_SYMBOLS/KERNEL_BIN/ no ?

imp added a reviewer: mmel.Mar 10 2023, 1:40 PM
imp updated this revision to Diff 118625.Mar 10 2023, 1:44 PM

docs

Harbormaster completed remote builds in B50270: Diff 118625.Mar 10 2023, 1:44 PM
imp edited the summary of this revision. (Show Details)Mar 10 2023, 1:44 PM
imp updated this revision to Diff 118626.Mar 10 2023, 1:46 PM

better docs

Harbormaster completed remote builds in B50271: Diff 118626.Mar 10 2023, 1:46 PM
imp edited the summary of this revision. (Show Details)Mar 10 2023, 1:50 PM
imp updated this revision to Diff 118627.Mar 10 2023, 1:52 PM

SYMBOLS -> BIN, commit message tweaks

Harbormaster completed remote builds in B50272: Diff 118627.Mar 10 2023, 1:52 PM
manu added a comment.Mar 10 2023, 2:00 PM

The only problem I see with disabling it by default is that we won't have kernel.bin in memstick images which can be used to boot on tegra board where this is the only possible way.

imp updated this revision to Diff 118629.Mar 10 2023, 2:13 PM

stupid missing && operator.

Harbormaster completed remote builds in B50273: Diff 118629.Mar 10 2023, 2:13 PM
imp updated this revision to Diff 118630.Mar 10 2023, 2:17 PM

sorry -- too many update --- this one fixes a comment

Harbormaster completed remote builds in B50274: Diff 118630.Mar 10 2023, 2:17 PM
mmel accepted this revision.Mar 22 2023, 6:53 AM

fyi, original idea was provide (not-preferred) way how to (limited) boot FreeBSD on a board with a problematic u-boot that might be locked or need lots of GPL or Linux specific utilities. It was easy for arm64 (where any u-boot can handle a booti image that is generic and has an easy format), but it's hard for armv7, where bootm needs an external program and the resulting image is not generic - it has a built-in load and boot address.
from my current point of view something like user submake stubs will be better (in simple words - be may include and run user definable makefile fragment) -> so system make can try to run this fragment for postprocessing

This revision is now accepted and ready to land.Mar 22 2023, 6:53 AM
imp added a comment.Oct 27 2023, 3:16 AM

Yea, submake stubs would be better... but we don't have those yet :)

Herald added a reviewer: andrew. · View Herald TranscriptOct 27 2023, 3:16 AM
Herald added a reviewer: andrew. · View Herald Transcript
Closed by commit rG34632ed1a495: arm: Introduce MK_KERNEL_BIN to control generation of kernel.bin (authored by imp). · Explain WhyOct 27 2023, 3:19 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG34632ed1a495: arm: Introduce MK_KERNEL_BIN to control generation of kernel.bin.

Revision Contents
Changeset List

PathSize
sys/
conf/
5 lines
6 lines
19 lines
9 lines
tools/
build/
options/
8 lines

Diff 129433

View Options

sys/conf/Makefile.arm

Loading...
View Options

sys/conf/Makefile.arm64

Loading...
View Options

sys/conf/kern.opts.mk

Loading...
View Options

sys/conf/kern.post.mk

Loading...
View Options

tools/build/options/WITH_KERNEL_BIN

Loading...