Remove sysctl 'kern.smp.forward_signal_enabled'
ClosedPublic
Actions

Authored by olce on Oct 20 2023, 1:51 PM.

Details

Reviewers

kib
markj
jhb

Commits

rG9d882de2da20: Remove sysctl 'kern.smp.forward_signal_enabled'

Summary

It seems this was an "emergency" knob to revert a newly introduced
behavior. Overall, we want better system-wide signal receive latency,
and it doesn't seem that some contrary policy was ever needed (and if
that comes up, it should rather be implemented, e.g., per-process).

Suggested by: kib
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54109
Build 50999: arc lint + arc unit

Event Timeline

olce created this revision.Oct 20 2023, 1:51 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2023, 1:51 PM

olce requested review of this revision.Oct 20 2023, 1:51 PM

Harbormaster completed remote builds in B54109: Diff 129152.Oct 20 2023, 1:51 PM

@kib Can this be MFCed, or falls under the KBI compatibility policy? If it can be MFCed, I'll merge it with D42285.

In D42315#965467, @olce.freebsd_certner.fr wrote:

@kib Can this be MFCed, or falls under the KBI compatibility policy? If it can be MFCed, I'll merge it with D42285.

I believe it is unused and we should not consider it as a part of ABI.

This revision is now accepted and ready to land.Oct 20 2023, 2:53 PM

I'm fine with merging it. This is only a foot-shooting knob.

Closed by commit rG9d882de2da20: Remove sysctl 'kern.smp.forward_signal_enabled' (authored by olce, committed by markj). · Explain WhyNov 21 2023, 6:36 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG9d882de2da20: Remove sysctl 'kern.smp.forward_signal_enabled'.