zfsctl_mounted_here(): Use vn_cross_single_mount()
Needs ReviewPublic
Actions

Authored by olce on Jul 3 2023, 12:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 10, 9:58 AM

	Unknown Object (File)
	Sun, Jul 6, 7:16 PM

	Unknown Object (File)
	Sun, Jul 6, 4:40 PM

	Unknown Object (File)
	Sat, Jul 5, 7:52 AM

	Unknown Object (File)
	Sat, Jul 5, 6:45 AM

	Unknown Object (File)
	Thu, Jul 3, 12:47 AM

	Unknown Object (File)
	Wed, Jul 2, 6:51 AM

	Unknown Object (File)
	Tue, Jul 1, 9:14 PM

Subscribers

Details

Reviewers

jah
mjg
kib
markj

Summary

This is an impact of the protocol change to act on the mount point(s) covering
a given vnode and in particular crossing them.

This commit is part of a series whose goal is to remove the VV_CROSSLOCK vnode
flag and logic and fix a timing-dependent deadlock between lookup and unmount.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52464
Build 49355: arc lint + arc unit

Event Timeline

olce created this revision.Jul 3 2023, 12:53 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptJul 3 2023, 12:53 PM

olce requested review of this revision.Jul 3 2023, 12:53 PM

Harbormaster completed remote builds in B52406: Diff 124126.Jul 3 2023, 12:53 PM

olce added a parent revision: D40855: nfsrvd_readdirplus(): Use vn_busy_mountedhere().Jul 3 2023, 1:03 PM

olce added a child revision: D40857: zfsctl_snapshot_vptocnp(): Use vn_busy_mountedhere().

Fix a bug where '*vpp' was set to NULL even when EJUSTRETURN is returned. Fix
probable build warnings on old versions.

Harbormaster completed remote builds in B52464: Diff 124251.Jul 6 2023, 8:59 PM

emaste added a subscriber: emaste.Jul 17 2023, 4:11 PM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

openzfs/

module/

os/

freebsd/

zfs/

zfs_ctldir.c

27 lines

Diff 124251

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c

zfsctl_mounted_here(): Use vn_cross_single_mount()Needs ReviewPublicActions