vfs_lookup(): Use vn_cross_mounts() to cross mount points
Needs ReviewPublic
Actions

Authored by olce on Jul 3 2023, 12:53 PM.

Details

Reviewers

jah
mjg
kib
markj

Summary

This commit is part of a series whose goal is to remove the VV_CROSSLOCK vnode
flag and logic and fix a timing-dependent deadlock between lookup and unmount.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52528
Build 49419: arc lint + arc unit

Event Timeline

olce created this revision.Jul 3 2023, 12:53 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2023, 12:53 PM

olce requested review of this revision.Jul 3 2023, 12:53 PM

Harbormaster completed remote builds in B52401: Diff 124121.Jul 3 2023, 12:53 PM

olce added a parent revision: D40850: VFS lookup: New vn_cross_single_mount() and vn_cross_mounts().Jul 3 2023, 1:03 PM

olce added a child revision: D40852: Remove VV_CROSSLOCK flag, and logic in nullfs and unionfs.

olce mentioned this in D40600: vfs_lookup(): remove VV_CROSSLOCK logic.Jul 3 2023, 3:24 PM

Rebase.

Harbormaster completed remote builds in B52472: Diff 124274.Jul 7 2023, 10:14 AM

olce removed a parent revision: D40850: VFS lookup: New vn_cross_single_mount() and vn_cross_mounts().Jul 9 2023, 6:08 PM

olce added a parent revision: D40953: vn_cross_mounts(): Inline the mountpoint detection test.

Revert to unlocking 'ni_dvp' when crossing mounts to avoid the NFS deadlock
problem.

Harbormaster completed remote builds in B52528: Diff 124408.Jul 9 2023, 6:12 PM

emaste added a subscriber: emaste.Jul 17 2023, 4:10 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_lookup.c

124 lines

Diff 124408

View Options

vfs_lookup(): Use vn_cross_mounts() to cross mount pointsNeeds ReviewPublicActions