zfsctl_snapshot_vptocnp(): Use vn_busy_mountedhere()
Needs ReviewPublic
Actions

Authored by olce on Jul 3 2023, 12:53 PM.

Details

Reviewers

jah
mjg
kib
markj

Summary

This is an impact of the protocol change to act on the mount point(s) covering
a given vnode and in particular crossing them.

This commit is (hopefully) the last in a series whose goal is to remove the
VV_CROSSLOCK vnode flag and logic and fix a timing-dependent deadlock between
lookup and unmount.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52407
Build 49298: arc lint + arc unit

Event Timeline

olce created this revision.Jul 3 2023, 12:53 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptJul 3 2023, 12:53 PM

olce requested review of this revision.Jul 3 2023, 12:53 PM

Harbormaster completed remote builds in B52407: Diff 124127.Jul 3 2023, 12:53 PM

olce added a parent revision: D40856: zfsctl_mounted_here(): Use vn_cross_single_mount().Jul 3 2023, 1:03 PM

Update the prediction predicate after vn_busy_mountedhere()'s change of contract.

Harbormaster completed remote builds in B52465: Diff 124252.Jul 6 2023, 9:02 PM

olce added a child revision: D40905: VFS: Remove 'vp_crossmp'.Jul 7 2023, 10:18 AM

olce added a child revision: D40954: vn_lock_pair(): Support passing LK_NODDLKTREAT.Jul 9 2023, 6:15 PM

olce removed a child revision: D40905: VFS: Remove 'vp_crossmp'.

emaste added a subscriber: emaste.Jul 17 2023, 4:12 PM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

openzfs/

module/

os/

freebsd/

zfs/

zfs_ctldir.c

20 lines

Diff 124127

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c

zfsctl_snapshot_vptocnp(): Use vn_busy_mountedhere()Needs ReviewPublicActions