Paths

Table of Contentst

Differential D40684

New login_getcapenum(): Allows to read named enum values
ClosedPublic
Actions

Authored by olce on Jun 21 2023, 12:38 PM.

Tags

None

Referenced Files

	F170675870: D40684.id123590.diff
	Sat, Sep 5, 11:31 PM

	F170662991: D40684.id123607.diff
	Sat, Sep 5, 9:36 PM

	F170606994: D40684.id133234.diff
	Sat, Sep 5, 3:05 PM

	F170606928: D40684.id123590.diff
	Sat, Sep 5, 3:05 PM

	F170606162: D40684.id123607.diff
	Sat, Sep 5, 3:00 PM

	F170605913: D40684.id.diff
	Sat, Sep 5, 2:58 PM

	F170596617: D40684.id133234.diff
	Sat, Sep 5, 2:00 PM

	Unknown Object (File)
	Sat, Sep 5, 6:15 AM

Subscribers

Details

Reviewers

yuripv
kevans
mjg
des
kib
emaste

Commits

rG37aaacd41016: New login_getcapenum(): Allows to read named enum values
rGfc7a8cb67754: New login_getcapenum(): Allows to read named enum values
rG90e914cd5ac1: New login_getcapenum(): Allows to read named enum values

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52230
Build 49121: arc lint + arc unit

Event Timeline

olce created this revision.Jun 21 2023, 12:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 21 2023, 12:38 PM

olce requested review of this revision.Jun 21 2023, 12:38 PM

Harbormaster completed remote builds in B52214: Diff 123590.Jun 21 2023, 12:38 PM

Fix interpretation of cgetstr()'s return code

Harbormaster completed remote builds in B52219: Diff 123596.Jun 21 2023, 1:30 PM

olce added a child revision: D40685: login_cap(3): Document login_getcapenum().Jun 21 2023, 1:31 PM

olce added a parent revision: D40345: login.conf(5): umask has no default value.Jun 21 2023, 1:37 PM

Remove erroneous unbreakable spaces.

Harbormaster completed remote builds in B52230: Diff 123607.Jun 21 2023, 2:12 PM

olce added reviewers: yuripv, kevans, mjg, des, kib.Jun 22 2023, 1:32 PM

emaste mentioned this in D40685: login_cap(3): Document login_getcapenum().Jan 23 2024, 2:49 PM

emaste added a subscriber: emaste.

emaste added inline comments.

lib/libutil/login_cap.c
770	it must be set to one of a list of values, yes?
782	Maybe "exists" rather than "found" or just "String is not listed in 'values'"

Address comments.

lib/libutil/login_cap.c
770	It is expected to, yes. It returns `-1` in case the value is a string but not one listed in `values`. I've reformulated this sentence.
782	I've reformulated.

Harbormaster completed remote builds in B55581: Diff 133234.Jan 23 2024, 9:35 PM

emaste accepted this revision.Jan 26 2024, 2:24 PM

This revision is now accepted and ready to land.Jan 26 2024, 2:24 PM

emaste mentioned this in D40687: setclassumask(): Accept 'inherit' as a value.Jan 26 2024, 2:29 PM

Closed by commit rG90e914cd5ac1: New login_getcapenum(): Allows to read named enum values (authored by olce). · Explain WhyJan 29 2024, 10:32 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG90e914cd5ac1: New login_getcapenum(): Allows to read named enum values.

olce added a commit: rGfc7a8cb67754: New login_getcapenum(): Allows to read named enum values.Feb 1 2024, 9:26 PM

olce added a commit: rG37aaacd41016: New login_getcapenum(): Allows to read named enum values.Feb 1 2024, 9:31 PM

Revision Contents
Changeset List

Path

Size

lib/

libutil/

2 lines

46 lines

Diff 123607

lib/libutil/login_cap.h

Loading...

lib/libutil/login_cap.c

Loading...