Differential D40674

bsd.sys.mk: Re-enable -Wunused-but-set-variable for clang 13+.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 23, 1:59 PM

	Unknown Object (File)
	Wed, Dec 17, 5:06 PM

	Unknown Object (File)
	Mon, Dec 15, 11:31 PM

	Unknown Object (File)
	Sun, Dec 14, 9:16 PM

	Unknown Object (File)
	Thu, Dec 11, 10:15 AM

	Unknown Object (File)
	Sat, Dec 6, 7:37 AM

	Unknown Object (File)
	Fri, Dec 5, 1:02 PM

	Unknown Object (File)
	Tue, Dec 2, 2:32 PM

View All 97 Files

Subscribers

Details

Reviewers

dim
emaste

Commits

rGd036adc4e913: bsd.sys.mk: Re-enable -Wunused-but-set-variable for clang 13+.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52209
Build 49100: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 20 2023, 4:34 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJun 20 2023, 4:34 PM

jhb requested review of this revision.Jun 20 2023, 4:34 PM

Harbormaster completed remote builds in B52209: Diff 123549.Jun 20 2023, 4:34 PM

jhb added a parent revision: D40673: rtld-elf: Mark tls_init_align __unused in free_tls for Variant I TLS..Jun 20 2023, 4:34 PM

I started on just trying to bring GCC up to par with clang (only disabling it for WARNS < 3) but accidentally had enabled it always for GCC when I got to the end, so I went ahead and just enabled it for clang as well and got make tinderbox working. The result is this stack/series (as well as about 20 commits or so I just pushed to main that were trivial enough to not warrant review IMO).

emaste accepted this revision.Jun 20 2023, 4:57 PM

This revision is now accepted and ready to land.Jun 20 2023, 4:57 PM

Great, let's prevent more of these getting into the tree! :)

Closed by commit rGd036adc4e913: bsd.sys.mk: Re-enable -Wunused-but-set-variable for clang 13+. (authored by jhb). · Explain WhyJun 28 2023, 7:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd036adc4e913: bsd.sys.mk: Re-enable -Wunused-but-set-variable for clang 13+..

Revision Contents
Changeset List

Path

Size

share/

mk/

3 lines

Diff 123549

share/mk/bsd.sys.mk

Loading...