bsdinstall: Remove set but unused variable.
AbandonedPublic
Actions

Authored by jhb on Jun 20 2023, 4:33 PM.

Details

Reviewers

nwhitehorn

Summary

Other places in this code do not check the return value of
geom_gettree so just remove the variable to stay consistent.

While here, fix a nearby style bug.

Reported by: GCC

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52194
Build 49085: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 20 2023, 4:33 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptJun 20 2023, 4:33 PM

jhb requested review of this revision.Jun 20 2023, 4:33 PM

Harbormaster completed remote builds in B52194: Diff 123534.Jun 20 2023, 4:33 PM

jhb added a parent revision: D40658: bsdinstall: Replace correct, but fragile, string builder with open_memstream..Jun 20 2023, 4:33 PM

jhb added a child revision: D40660: hyperv/kvp: Remove set but unused variables..

jhb added a reviewer: nwhitehorn.Jun 20 2023, 4:37 PM

emaste added a subscriber: emaste.Jun 20 2023, 7:49 PM

emaste added inline comments.

usr.sbin/bsdinstall/partedit/scripted.c
77	maybe we should handle the error instead? will `provider_for_name` handle the case that `geom_gettree` failed?

Possibly we could add the error handling, but it's not something we've needed since bsdinstall was written?

usr.sbin/bsdinstall/partedit/scripted.c
100	We don't handle the error here.
187	Or here.

jhb added inline comments.Jun 27 2023, 11:14 PM

usr.sbin/bsdinstall/partedit/scripted.c
77	See D40779 for an alternate version that tries to handle the errors (though there isn't really a good recourse if this fails in most cases)

jhb abandoned this revision.Jun 28 2023, 6:11 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

scripted.c

11 lines

Diff 123534

View Options

usr.sbin/bsdinstall/partedit/scripted.c

bsdinstall: Remove set but unused variable.AbandonedPublicActions