Page MenuHomeFreeBSD

camdd: Remove some dead code but also try to make -E functional.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 11:46 PM
Unknown Object (File)
Wed, Sep 17, 4:01 PM
Unknown Object (File)
Sep 9 2025, 8:18 PM
Unknown Object (File)
Sep 9 2025, 10:18 AM
Unknown Object (File)
Sep 6 2025, 5:17 PM
Unknown Object (File)
Sep 6 2025, 9:06 AM
Unknown Object (File)
Sep 3 2025, 8:01 PM
Unknown Object (File)
Aug 30 2025, 1:34 PM
Subscribers

Details

Summary
  • Pass down the top-level arglist from main down to camdd_rw and use it in place of the hardcoded CAMDD_ARG_ERR_RECOVER when calling camdd_probe_pass. This now disables error recovery by default unless -E is specified.
  • Use the return value of parse_btl to determine if an explicit LUN was specified.
  • Remove most CAMDD_ARG_* flags that are only set and never checked. CAMDD_ARG_VERBOSE remains, but could perhaps be removed (and possibly -v should be removed as well since it is currently a no-op).

Reported by: clang -Wunused-but-set-variable (arglist in main)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable