Page MenuHomeFreeBSD

camdd: Remove some dead code but also try to make -E functional.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:34 PM.
Tags
None
Referenced Files
F170102976: D40666.id123541.diff
Thu, Sep 3, 12:43 PM
F169957965: D40666.id123913.diff
Thu, Sep 3, 2:42 AM
F169933393: D40666.id.diff
Thu, Sep 3, 12:39 AM
Unknown Object (File)
Wed, Sep 2, 3:07 PM
Unknown Object (File)
Wed, Sep 2, 2:07 PM
Unknown Object (File)
Wed, Sep 2, 8:12 AM
Unknown Object (File)
Tue, Sep 1, 8:20 PM
Unknown Object (File)
Tue, Sep 1, 8:20 PM
Subscribers

Details

Summary
  • Pass down the top-level arglist from main down to camdd_rw and use it in place of the hardcoded CAMDD_ARG_ERR_RECOVER when calling camdd_probe_pass. This now disables error recovery by default unless -E is specified.
  • Use the return value of parse_btl to determine if an explicit LUN was specified.
  • Remove most CAMDD_ARG_* flags that are only set and never checked. CAMDD_ARG_VERBOSE remains, but could perhaps be removed (and possibly -v should be removed as well since it is currently a no-op).

Reported by: clang -Wunused-but-set-variable (arglist in main)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable