Page MenuHomeFreeBSD

camdd: Remove some dead code but also try to make -E functional.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:34 PM.
Tags
None
Referenced Files
F169531910: D40666.diff
Tue, Sep 1, 8:20 PM
F169531898: D40666.diff
Tue, Sep 1, 8:20 PM
Unknown Object (File)
Tue, Sep 1, 2:28 AM
Unknown Object (File)
Mon, Aug 31, 11:47 PM
Unknown Object (File)
Mon, Aug 31, 9:31 AM
Unknown Object (File)
Sat, Aug 29, 9:16 PM
Unknown Object (File)
Sat, Aug 29, 9:07 PM
Unknown Object (File)
Wed, Aug 26, 4:02 PM
Subscribers

Details

Summary
  • Pass down the top-level arglist from main down to camdd_rw and use it in place of the hardcoded CAMDD_ARG_ERR_RECOVER when calling camdd_probe_pass. This now disables error recovery by default unless -E is specified.
  • Use the return value of parse_btl to determine if an explicit LUN was specified.
  • Remove most CAMDD_ARG_* flags that are only set and never checked. CAMDD_ARG_VERBOSE remains, but could perhaps be removed (and possibly -v should be removed as well since it is currently a no-op).

Reported by: clang -Wunused-but-set-variable (arglist in main)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable