Page MenuHomeFreeBSD

camdd: Remove some dead code but also try to make -E functional.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:34 PM.
Tags
None
Referenced Files
F86116851: D40666.diff
Sat, Jun 15, 5:26 PM
Unknown Object (File)
Wed, May 22, 11:15 PM
Unknown Object (File)
Mar 13 2024, 3:27 PM
Unknown Object (File)
Mar 13 2024, 3:27 PM
Unknown Object (File)
Mar 13 2024, 3:27 PM
Unknown Object (File)
Mar 10 2024, 10:29 AM
Unknown Object (File)
Feb 8 2024, 6:44 PM
Unknown Object (File)
Feb 5 2024, 9:11 AM
Subscribers

Details

Summary
  • Pass down the top-level arglist from main down to camdd_rw and use it in place of the hardcoded CAMDD_ARG_ERR_RECOVER when calling camdd_probe_pass. This now disables error recovery by default unless -E is specified.
  • Use the return value of parse_btl to determine if an explicit LUN was specified.
  • Remove most CAMDD_ARG_* flags that are only set and never checked. CAMDD_ARG_VERBOSE remains, but could perhaps be removed (and possibly -v should be removed as well since it is currently a no-op).

Reported by: clang -Wunused-but-set-variable (arglist in main)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52201
Build 49092: arc lint + arc unit