Page MenuHomeFreeBSD

bsdinstall: Replace correct, but fragile, string builder with open_memstream.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
F156474134: D40658.id123533.diff
Wed, May 13, 10:23 PM
F156473255: D40658.diff
Wed, May 13, 10:16 PM
F156473205: D40658.diff
Wed, May 13, 10:15 PM
Unknown Object (File)
Wed, May 6, 3:02 AM
Unknown Object (File)
Thu, Apr 30, 5:24 PM
Unknown Object (File)
Mon, Apr 27, 3:44 PM
Unknown Object (File)
Mon, Apr 20, 2:09 PM
Unknown Object (File)
Wed, Apr 15, 4:25 AM
Subscribers

Details

Summary

The old one triggered a false positive -Warray-bounds from GCC (the
compiler assumed len was always 0), but it was also fragile with
manually computed lengths paired with strcat vs using a string
builder.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable