Page MenuHomeFreeBSD

bsdinstall: Replace correct, but fragile, string builder with open_memstream.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 7:35 AM
Unknown Object (File)
Sun, Aug 9, 5:46 PM
Unknown Object (File)
Sat, Aug 8, 7:47 PM
Unknown Object (File)
Sat, Aug 8, 3:09 AM
Unknown Object (File)
Sat, Aug 8, 2:59 AM
Unknown Object (File)
Fri, Aug 7, 6:36 AM
Unknown Object (File)
Fri, Aug 7, 6:36 AM
Unknown Object (File)
Fri, Aug 7, 6:36 AM
Subscribers

Details

Summary

The old one triggered a false positive -Warray-bounds from GCC (the
compiler assumed len was always 0), but it was also fragile with
manually computed lengths paired with strcat vs using a string
builder.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable