fifolog: Trim some dead code and unused variables.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:33 PM.

Details

Reviewers

phk
emaste

Commits

rG4a0b57b0b4cb: fifolog: Trim some dead code and unused variables.

Summary

The gmt_ptr and gmt variables are not used, so the call to gmtime can
be removed entirely. In addition, there isn't a need to call
localtime twice.

Reported by: GCC -Wunused-but-set-variable

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 20 2023, 4:33 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 4:33 PM

jhb requested review of this revision.Jun 20 2023, 4:33 PM

Harbormaster completed remote builds in B52191: Diff 123531.Jun 20 2023, 4:33 PM

jhb added a parent revision: D40655: camdd: Remove set but unused variables..Jun 20 2023, 4:33 PM

jhb added a child revision: D40657: acpidump: Remove set but unused variable..

jhb added reviewers: phk, emaste.Jun 20 2023, 4:36 PM

Dead code removal looks good to me, will defer to @phk to comment on whether the bug is actually missing code.

This revision is now accepted and ready to land.Jun 20 2023, 4:53 PM

I think this is OK.

FreeBSD's fifolog was originally extracted from a larger and more specialized fifolog which (also) logged some application specific data for rapid indexing, and I think the GM timestamps was part of that.

Closed by commit rG4a0b57b0b4cb: fifolog: Trim some dead code and unused variables. (authored by jhb). · Explain WhyJun 20 2023, 9:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4a0b57b0b4cb: fifolog: Trim some dead code and unused variables..

Revision Contents
Changeset List

Path

Size

usr.sbin/

fifolog/

lib/

getdate.y

14 lines

Diff 123566

View Options

usr.sbin/fifolog/lib/getdate.y

fifolog: Trim some dead code and unused variables.ClosedPublicActions