Page MenuHomeFreeBSD

fifolog: Trim some dead code and unused variables.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 3:39 PM
Unknown Object (File)
Sun, Oct 5, 2:47 AM
Unknown Object (File)
Sat, Oct 4, 3:39 AM
Unknown Object (File)
Wed, Oct 1, 10:47 AM
Unknown Object (File)
Wed, Oct 1, 2:19 AM
Unknown Object (File)
Mon, Sep 29, 4:06 AM
Unknown Object (File)
Sat, Sep 27, 5:32 AM
Unknown Object (File)
Sat, Sep 27, 4:49 AM
Subscribers

Details

Summary

The gmt_ptr and gmt variables are not used, so the call to gmtime can
be removed entirely. In addition, there isn't a need to call
localtime twice.

Reported by: GCC -Wunused-but-set-variable

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 20 2023, 4:33 PM

Dead code removal looks good to me, will defer to @phk to comment on whether the bug is actually missing code.

This revision is now accepted and ready to land.Jun 20 2023, 4:53 PM

I think this is OK.

FreeBSD's fifolog was originally extracted from a larger and more specialized fifolog which (also) logged some application specific data for rapid indexing, and I think the GM timestamps was part of that.