Page MenuHomeFreeBSD
Differential D40656

fifolog: Trim some dead code and unused variables.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 8:44 AM
Unknown Object (File)
Sun, Nov 23, 1:27 AM
Unknown Object (File)
Tue, Nov 18, 3:24 AM
Unknown Object (File)
Tue, Nov 4, 4:10 AM
Unknown Object (File)
Oct 27 2025, 12:32 PM
Unknown Object (File)
Oct 26 2025, 11:55 PM
Unknown Object (File)
Oct 23 2025, 1:44 AM
Unknown Object (File)
Oct 20 2025, 3:27 AM
View All Files
Subscribers
imp

Details

Reviewers
phk
emaste
Commits
rG4a0b57b0b4cb: fifolog: Trim some dead code and unused variables.
Summary

The gmt_ptr and gmt variables are not used, so the call to gmtime can
be removed entirely. In addition, there isn't a need to call
localtime twice.

Reported by: GCC -Wunused-but-set-variable

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52191
Build 49082: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 20 2023, 4:33 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 4:33 PM
jhb requested review of this revision.Jun 20 2023, 4:33 PM
Harbormaster completed remote builds in B52191: Diff 123531.Jun 20 2023, 4:33 PM
jhb added a parent revision: D40655: camdd: Remove set but unused variables..Jun 20 2023, 4:33 PM
jhb added a child revision: D40657: acpidump: Remove set but unused variable..
jhb added reviewers: phk, emaste.Jun 20 2023, 4:36 PM
emaste accepted this revision.Jun 20 2023, 4:53 PM

Dead code removal looks good to me, will defer to @phk to comment on whether the bug is actually missing code.

This revision is now accepted and ready to land.Jun 20 2023, 4:53 PM
phk accepted this revision.Jun 20 2023, 8:53 PM

I think this is OK.

FreeBSD's fifolog was originally extracted from a larger and more specialized fifolog which (also) logged some application specific data for rapid indexing, and I think the GM timestamps was part of that.

Closed by commit rG4a0b57b0b4cb: fifolog: Trim some dead code and unused variables. (authored by jhb). · Explain WhyJun 20 2023, 9:04 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG4a0b57b0b4cb: fifolog: Trim some dead code and unused variables..

Revision Contents
Changeset List

PathSize
usr.sbin/
fifolog/
lib/
14 lines

Diff 123531

View Options

usr.sbin/fifolog/lib/getdate.y

Loading...