rtld-elf: Mark tls_init_align __unused in free_tls for Variant I TLS.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:34 PM.

Details

Reviewers

kib
jrtc27

Commits

rG38efd4df23cf: rtld-elf: Mark tls_init_align __unused in free_tls for Variant I TLS.

Summary

Some architectures (powerpc and RISC-V) always use 0 for the post TLS
size in which case tls_init_align isn't used by
calculate_tls_post_size. Use __unused to quiet the warning for these
platforms.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52208
Build 49099: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 20 2023, 4:34 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptJun 20 2023, 4:34 PM

jhb requested review of this revision.Jun 20 2023, 4:34 PM

Harbormaster completed remote builds in B52208: Diff 123548.Jun 20 2023, 4:34 PM

jhb added a parent revision: D40672: efi loader: Move 'module' variable under #ifdef MODINFOMD_MODULEP..Jun 20 2023, 4:34 PM

jhb added a child revision: D40674: bsd.sys.mk: Re-enable -Wunused-but-set-variable for clang 13+..

jhb added reviewers: kib, jrtc27.Jun 20 2023, 4:44 PM

kib accepted this revision.Jun 20 2023, 4:56 PM

This revision is now accepted and ready to land.Jun 20 2023, 4:56 PM

Closed by commit rG38efd4df23cf: rtld-elf: Mark tls_init_align __unused in free_tls for Variant I TLS. (authored by jhb). · Explain WhyJun 20 2023, 7:39 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG38efd4df23cf: rtld-elf: Mark tls_init_align __unused in free_tls for Variant I TLS..

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld.c

2 lines

Diff 123548

View Options

rtld-elf: Mark tls_init_align __unused in free_tls for Variant I TLS.ClosedPublicActions