arm64: print '0x' before hex values
ClosedPublic
Actions

Authored by christos on Jun 17 2023, 12:46 PM.

Details

Reviewers

markj
mhorne
manu
imp
andrew

Commits

rGe5c7aa5c703e: arm64: print '0x' before hex values

Summary

Not making it explicit that we're printing values in hex can be
misleading when the number doesn't contain hex-only symbols (a-f). A
good example of this is print_gp_register(), where we print "(func +
offset)"; if the offset doesn't contain a-f symbols, it's not
immediately clear if that value is in decimal or hex.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52114
Build 49005: arc lint + arc unit

Event Timeline

christos created this revision.Jun 17 2023, 12:46 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 17 2023, 12:46 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

christos requested review of this revision.Jun 17 2023, 12:46 PM

Harbormaster completed remote builds in B52112: Diff 123364.Jun 17 2023, 12:46 PM

Forgot some printfs.

Harbormaster completed remote builds in B52113: Diff 123365.Jun 17 2023, 12:56 PM

Use '0x' instead of '#', fix width issues.

Harbormaster completed remote builds in B52114: Diff 123366.Jun 17 2023, 1:31 PM

What was wrong with #? We use it all over the place.

This revision is now accepted and ready to land.Jun 17 2023, 2:45 PM

In D40583#924040, @imp wrote:

What was wrong with #? We use it all over the place.

It doesn't print '0x' if the value is 0, and it also messes up column alignment. We could replace '0x' with '#' wherever we do not care about alignment, if you insist, however.

In D40583#924043, @christos wrote:

In D40583#924040, @imp wrote:

What was wrong with #? We use it all over the place.

It doesn't print '0x' if the value is 0, and it also messes up column alignment. We could replace '0x' with '#' wherever we do not care about alignment, if you insist, however.