Page MenuHomeFreeBSD

ifconfig: fix comparison in printmimo()
ClosedPublic

Authored by melifaro on May 27 2023, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 3, 8:26 AM
Unknown Object (File)
Wed, Sep 2, 9:07 PM
Unknown Object (File)
Wed, Sep 2, 4:33 PM
Unknown Object (File)
Wed, Sep 2, 8:36 AM
Unknown Object (File)
Wed, Sep 2, 2:46 AM
Unknown Object (File)
Wed, Sep 2, 12:20 AM
Unknown Object (File)
Tue, Sep 1, 8:35 AM
Unknown Object (File)
Mon, Aug 31, 8:29 AM
Subscribers

Details

Summary

Currently compiler yells at printmimo() with the following warning:

/usr/home/melifaro/free/head/sbin/ifconfig/ifieee80211.c:3716:17: error: comparison of array 'mi->ch[i].rssi' not equal to a null pointer is always true [-Werror,-Wtautological-pointer-compare]
                if (mi->ch[i].rssi != 0) {
                    ~~~~~~~~~~^~~~    ~

To check:

--- a/sbin/ifconfig/Makefile
+++ b/sbin/ifconfig/Makefile
@@ -80,7 +80,8 @@ CFLAGS+=-DWITHOUT_NETLINK
 MAN=   ifconfig.8

 CFLAGS+= -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wnested-externs
-WARNS?=        2
+CFLAGS+=-Wno-error=unused-parameter -Wno-error=shadow
+#WARNS?=       2

I have no domain knowledge whether the fix is valid or not, but the code before 617f8b101e7f checked rssi[0].

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable