Paths

Table of Contentst

Differential D40384

xregs_via_sig: Add avx registers to test
ClosedPublic
Actions

Authored by dchagin on Jun 1 2023, 8:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 11, 7:18 AM

	Unknown Object (File)
	Wed, May 22, 8:23 AM

	Unknown Object (File)
	Wed, May 22, 5:24 AM

	Unknown Object (File)
	May 16 2024, 3:35 AM

	Unknown Object (File)
	May 16 2024, 12:26 AM

	Unknown Object (File)
	May 15 2024, 7:46 PM

	Unknown Object (File)
	May 15 2024, 6:34 PM

	Unknown Object (File)
	May 9 2024, 9:16 AM

View All 60 Files

Subscribers

Details

Reviewers

kib
jhb

Commits

rGc8dbef44ffbe: xregs_sig: Add avx registers to test

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51886
Build 48777: arc lint + arc unit

Event Timeline

dchagin created this revision.Jun 1 2023, 8:48 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2023, 8:48 PM

dchagin requested review of this revision.Jun 1 2023, 8:48 PM

Harbormaster completed remote builds in B51848: Diff 122733.Jun 1 2023, 8:48 PM

dchagin added reviewers: kib, jhb.Jun 1 2023, 8:52 PM

Fix build on Linux

Harbormaster completed remote builds in B51850: Diff 122739.Jun 1 2023, 9:10 PM

kib added inline comments.Jun 1 2023, 10:44 PM

tools/test/xregs_via_sig/c2x2c_amd64.S
20 ↗	(On Diff #122739)	We traditionally spell the directive as '.globl'
33 ↗	(On Diff #122739)	movl $1, %eax You do cmpl $1, %eax after the function call.
36 ↗	(On Diff #122739)	xorl %eax, %eax It is same as xorq you used, but avoids prefix. You do not need %rax anyway.

Done, thank you

Harbormaster completed remote builds in B51859: Diff 122751.Jun 2 2023, 12:12 PM

kib added inline comments.Jun 2 2023, 12:53 PM

tools/test/xregs_via_sig/c2x2c_amd64.S
24 ↗	(On Diff #122751)	CPUID instruction corrupts %ebp, which is callee-saved register.

dchagin added inline comments.Jun 2 2023, 1:36 PM

tools/test/xregs_via_sig/c2x2c_amd64.S
24 ↗	(On Diff #122751)	you mean %ebx?

jhb added inline comments.Jun 2 2023, 5:36 PM

tools/test/xregs_via_sig/c2x2c_amd64.S
8 ↗	(On Diff #122751)	I think xregs_bank should be in C instead. I would rather that you just export `cpu_to_xmm`, `cpu_to_ymm`, etc., invoke cpuid once during startup to save the desired bank in a global in C and have C wrappers to choose which MD routines to invoke.

kib added inline comments.Jun 2 2023, 7:20 PM

tools/test/xregs_via_sig/c2x2c_amd64.S
24 ↗	(On Diff #122751)	Yes %ebx sorry

Reworked, based on D40410 now

Herald added subscribers: emaste, andrew. · View Herald TranscriptJun 3 2023, 5:08 PM

Harbormaster completed remote builds in B51885: Diff 122800.Jun 3 2023, 5:08 PM

fix arm64 xregs_banks_max

Harbormaster completed remote builds in B51886: Diff 122804.Jun 3 2023, 5:25 PM

dchagin added a parent revision: D40410: xregs_sig: Add a ability to handle multiple register banks.Jun 3 2023, 5:27 PM

kib accepted this revision.Jun 3 2023, 7:28 PM

kib added inline comments.

tools/test/xregs_sig/c2x2c_amd64.S
23	Please use the size instruction suffixes consistently

This revision is now accepted and ready to land.Jun 3 2023, 7:28 PM

Closed by commit rGc8dbef44ffbe: xregs_sig: Add avx registers to test (authored by dchagin). · Explain WhyJun 4 2023, 9:09 AM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rGc8dbef44ffbe: xregs_sig: Add avx registers to test.

Revision Contents
Changeset List

Path

Size

tools/

test/

xregs_sig/

c2x2c_aarch64.S

8 lines

85 lines

14 lines

Diff 122804

tools/test/xregs_sig/c2x2c_aarch64.S

Loading...

tools/test/xregs_sig/c2x2c_amd64.S

Loading...

tools/test/xregs_sig/xregs_sig.c

Loading...