Details
Details
- Reviewers
kib jhb - Commits
- rGc8dbef44ffbe: xregs_sig: Add avx registers to test
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
20 ↗ | (On Diff #122739) | We traditionally spell the directive as '.globl' |
33 ↗ | (On Diff #122739) | movl $1, %eax |
36 ↗ | (On Diff #122739) | xorl %eax, %eax |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
24 ↗ | (On Diff #122751) | CPUID instruction corrupts %ebp, which is callee-saved register. |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
24 ↗ | (On Diff #122751) | you mean %ebx? |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
8 ↗ | (On Diff #122751) | I think xregs_bank should be in C instead. I would rather that you just export cpu_to_xmm, cpu_to_ymm, etc., invoke cpuid once during startup to save the desired bank in a global in C and have C wrappers to choose which MD routines to invoke. |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
24 ↗ | (On Diff #122751) | Yes %ebx sorry |
tools/test/xregs_sig/c2x2c_amd64.S | ||
---|---|---|
23 | Please use the size instruction suffixes consistently |