Page MenuHomeFreeBSD
Differential D40410

xregs_sig: Add a ability to handle multiple register banks
ClosedPublic
Actions

Authored by dchagin on Jun 3 2023, 4:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 25, 3:48 AM
Unknown Object (File)
Tue, Dec 16, 4:18 AM
Unknown Object (File)
Tue, Dec 9, 3:50 PM
Unknown Object (File)
Nov 29 2025, 9:07 PM
Unknown Object (File)
Nov 23 2025, 10:51 AM
Unknown Object (File)
Nov 21 2025, 8:09 AM
Unknown Object (File)
Nov 19 2025, 5:40 PM
Unknown Object (File)
Nov 19 2025, 5:02 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
kib
jhb
Commits
rG0be13a45f7cb: xregs_sig: Add a ability to handle multiple register banks
Summary

While here replace the .global directive by traditionally used .globl.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Jun 3 2023, 4:58 PM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJun 3 2023, 4:58 PM
dchagin requested review of this revision.Jun 3 2023, 4:58 PM
Harbormaster completed remote builds in B51884: Diff 122796.Jun 3 2023, 4:58 PM
dchagin mentioned this in D40384: xregs_via_sig: Add avx registers to test.Jun 3 2023, 5:08 PM
dchagin added a child revision: D40384: xregs_via_sig: Add avx registers to test.Jun 3 2023, 5:27 PM
dchagin added reviewers: kib, jhb.
kib added inline comments.Jun 3 2023, 7:28 PM
tools/test/xregs_sig/c2x2c_aarch64.S
7–8

I think you should also add the .text directive there

tools/test/xregs_sig/c2x2c_amd64.S
7–8

Also .text

tools/test/xregs_sig/xregs_sig.c
61
dchagin updated this revision to Diff 122809.Jun 3 2023, 8:04 PM

Done, .text added

Harbormaster completed remote builds in B51889: Diff 122809.Jun 3 2023, 8:04 PM
kib added inline comments.Jun 3 2023, 8:56 PM
tools/test/xregs_sig/xregs_sig.c
61

And what about this?

dchagin updated this revision to Diff 122813.Jun 3 2023, 9:14 PM

whoops, missed it due to phabric email doesn't show it,
constify struct xregs_banks, thank you

Harbormaster completed remote builds in B51892: Diff 122813.Jun 3 2023, 9:14 PM
kib accepted this revision.Jun 3 2023, 9:24 PM
This revision is now accepted and ready to land.Jun 3 2023, 9:24 PM
Closed by commit rG0be13a45f7cb: xregs_sig: Add a ability to handle multiple register banks (authored by dchagin). · Explain WhyJun 4 2023, 9:09 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG0be13a45f7cb: xregs_sig: Add a ability to handle multiple register banks.

Revision Contents
Changeset List

PathSize
tools/
test/
xregs_sig/
18 lines
18 lines
128 lines

Diff 122819

View Options

tools/test/xregs_sig/c2x2c_aarch64.S

Loading...
View Options

tools/test/xregs_sig/c2x2c_amd64.S

Loading...
View Options

tools/test/xregs_sig/xregs_sig.c

Loading...