Details
Details
- Reviewers
kib jhb - Commits
- rGc8dbef44ffbe: xregs_sig: Add avx registers to test
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 51848 Build 48739: arc lint + arc unit
Event Timeline
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
24 | CPUID instruction corrupts %ebp, which is callee-saved register. |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
24 | you mean %ebx? |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
8 | I think xregs_bank should be in C instead. I would rather that you just export cpu_to_xmm, cpu_to_ymm, etc., invoke cpuid once during startup to save the desired bank in a global in C and have C wrappers to choose which MD routines to invoke. |
tools/test/xregs_via_sig/c2x2c_amd64.S | ||
---|---|---|
24 | Yes %ebx sorry |
tools/test/xregs_sig/c2x2c_amd64.S | ||
---|---|---|
23 ↗ | (On Diff #122804) | Please use the size instruction suffixes consistently |