Page MenuHomeFreeBSD
Differential D40103

netlink: add support for adding/deleting interface addresses
ClosedPublic
Actions

Authored by melifaro on May 15 2023, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 21, 12:22 AM
Unknown Object (File)
Fri, Dec 5, 10:25 PM
Unknown Object (File)
Sat, Nov 29, 1:57 PM
Unknown Object (File)
Nov 9 2025, 9:06 PM
Unknown Object (File)
Nov 9 2025, 9:05 PM
Unknown Object (File)
Nov 9 2025, 9:05 PM
Unknown Object (File)
Nov 9 2025, 4:37 PM
Unknown Object (File)
Nov 6 2025, 1:54 PM
View All Files
Subscribers
glebius
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rG10b94e406444: netlink: add support for adding/deleting interface addresses
Test Plan
kyua test -k /usr/tests/sys/netlink/Kyuafile 'test_rtnl_ifaddr.py'
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_add_4[host]  ->  passed  [0.278s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_add_4[prefix]  ->  passed  [0.385s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_add_6[gu_host]  ->  passed  [0.298s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_add_6[gu_prefix]  ->  passed  [0.380s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_address-ipv4_host]  ->  passed  [0.441s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_address-ipv4_prefix]  ->  passed  [0.308s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_address-ipv6_gu_host]  ->  passed  [0.309s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_address-ipv6_gu_prefix]  ->  passed  [0.337s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_local-ipv4_host]  ->  passed  [0.409s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_local-ipv4_prefix]  ->  passed  [0.303s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_local-ipv6_gu_host]  ->  passed  [0.337s]
test_rtnl_ifaddr.py:TestRtNlAddIfaddrLo::test_del[ifa_local-ipv6_gu_prefix]  ->  passed  [0.359s]
test_rtnl_ifaddr.py:TestRtNlIfaddrList::test_46_filter_family_compat  ->  passed  [0.356s]
test_rtnl_ifaddr.py:TestRtNlIfaddrList::test_46_filter_iface  ->  passed  [0.369s]
test_rtnl_ifaddr.py:TestRtNlIfaddrList::test_46_nofilter  ->  passed  [0.326s]
test_rtnl_ifaddr.py:TestRtNlIfaddrList::test_4_broadcast  ->  passed  [0.326s]
test_rtnl_ifaddr.py:TestRtNlIfaddrList::test_6_broadcast  ->  passed  [0.352s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_4  ->  passed  [0.314s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_4_carp  ->  passed  [0.339s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_4_empty_addr  ->  passed  [0.295s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_4_empty_ifindex  ->  passed  [0.298s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_4_empty_message  ->  passed  [0.313s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6  ->  passed  [0.337s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_carp  ->  passed  [0.301s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_flags[autoconf,deprecated]  ->  passed  [0.309s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_flags[autoconf]  ->  passed  [0.333s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_flags[deprecated]  ->  passed  [0.319s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_flags[prefer_source]  ->  passed  [0.309s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_lifetime  ->  passed  [0.291s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_address-ipv4_host]  ->  passed  [0.327s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_address-ipv4_prefix]  ->  passed  [0.335s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_address-ipv6_gu_host]  ->  passed  [0.331s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_address-ipv6_gu_prefix]  ->  passed  [0.320s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_local-ipv4_host]  ->  passed  [0.339s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_local-ipv4_prefix]  ->  passed  [0.360s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_local-ipv6_gu_host]  ->  passed  [0.350s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_del[ifa_local-ipv6_gu_prefix]  ->  passed  [0.332s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_4[dst_inside_24]  ->  passed  [0.334s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_4[dst_inside_30]  ->  passed  [0.352s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_4[dst_inside_31]  ->  passed  [0.321s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_4[dst_outside_30]  ->  passed  [0.343s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_4[dst_outside_32]  ->  passed  [0.428s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_6[dst_inside_127]  ->  skipped: /usr/tests/sys/netlink/test_rtnl_ifaddr.py:557: AssertionError  [0.373s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_6[dst_inside_64]  ->  skipped: /usr/tests/sys/netlink/test_rtnl_ifaddr.py:557: AssertionError  [0.342s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_6[dst_outside_128]  ->  passed  [0.316s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_add_6[dst_outside_64]  ->  skipped: /usr/tests/sys/netlink/test_rtnl_ifaddr.py:557: AssertionError  [0.458s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ip6_dst_outside_128]  ->  passed  [0.366s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ipv4_dst_inside_30]  ->  passed  [0.366s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ipv4_dst_outside_32]  ->  passed  [0.291s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr-ip6_dst_outside_128]  ->  passed  [0.363s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr-ipv4_dst_inside_30]  ->  passed  [0.350s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr-ipv4_dst_outside_32]  ->  passed  [0.367s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_local=addr-ip6_dst_outside_128]  ->  passed  [0.323s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_local=addr-ipv4_dst_inside_30]  ->  passed  [0.392s]
test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_local=addr-ipv4_dst_outside_32]  ->  passed  [0.338s]

Results file id is usr_tests_sys_netlink.20230515-120253-906199
Results saved to /home/melifaro/.kyua/store/results.usr_tests_sys_netlink.20230515-120253-906199.db

55/55 passed (0 failed)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/atf_python/sys/netlink/netlink_route.py:417E501PEP8 E501
Errortests/atf_python/sys/netlink/netlink_route.py:418E501PEP8 E501
Errortests/atf_python/sys/netlink/netlink_route.py:419E501PEP8 E501
Errortests/atf_python/sys/netlink/netlink_route.py:420E501PEP8 E501
Errortests/atf_python/sys/netlink/netlink_route.py:517E501PEP8 E501
Errortests/atf_python/sys/netlink/netlink_route.py:541E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:49E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:58E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:59E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:62E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:71E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:77E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:78E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:87E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:94E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:111E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:113E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:209E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:223E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:535E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:568E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:569E501PEP8 E501
Errortests/sys/netlink/test_rtnl_ifaddr.py:570E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 51500
Build 48391: arc lint + arc unit

Event Timeline

melifaro created this revision.May 15 2023, 12:00 PM
Herald added subscribers: glebius, imp. · View Herald TranscriptMay 15 2023, 12:00 PM
melifaro requested review of this revision.May 15 2023, 12:00 PM
Harbormaster completed remote builds in B51500: Diff 121961.May 15 2023, 12:00 PM
melifaro edited the summary of this revision. (Show Details)May 15 2023, 12:04 PM
melifaro edited the test plan for this revision. (Show Details)
melifaro added a reviewer: network.
This revision was not accepted when it landed; it landed in state Needs Review.May 16 2023, 7:40 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG10b94e406444: netlink: add support for adding/deleting interface addresses (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG10b94e406444: netlink: add support for adding/deleting interface addresses.

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
344 lines
4 lines
tests/
atf_python/
sys/
netlink/
223 lines
sys/
netlink/
586 lines

Diff 121961

View Options

sys/netlink/route/iface.c

Loading...
View Options

sys/netlink/route/ifaddrs.h

Loading...
View Options

tests/atf_python/sys/netlink/netlink_route.py

Loading...
View Options

tests/sys/netlink/test_rtnl_ifaddr.py

Loading...