in if_llmaddr_count() there's check against AF_LINK, is this line change identical ?

u_int   
if_llmaddr_count(if_t ifp)
{       
...
        CK_STAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link)
                 if (ifma->ifma_addr->sa_family == AF_LINK)
                         count++;
...
        return (count);
}

Set flags to wrong if. Should be VF.

"in transparent VF mode.\n" is truncated.

Should use if_name()

if_getinputfn()

SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tso_max",
	    CTLFLAG_RD, &ifp->if_hw_tsomax, 0, "max TSO size");

tso_max sysctl node is readonly, is if_sethwtsomax() really needed ?

Ditto

Ditto

CC @whu
Originally use atomic_clear_int(), is the change sufficient ?

Atomics @whu

You're right. Maybe I need a new API, if_has_multi(), for this.

Oops, I misread the sysctl declaration.