Differential D39493

IfAPI: Add if_maddr_empty() to check for any maddrs
ClosedPublic
Actions

Authored by jhibbits on Apr 10 2023, 7:14 PM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rGf766d1d5a7c6: IfAPI: Add if_maddr_empty() to check for any maddrs

Summary

if_llmaddr_count() only counts link-level multicast addresses.
hv_netvsc(4) needs to know if there are any multicast addresses. Since
hv_netvsc(4) is the only instance where this would be used, make it a
simple boolean. If others need a if_maddr_count(), that can be added in
the future.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Apr 10 2023, 7:14 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptApr 10 2023, 7:14 PM

jhibbits requested review of this revision.Apr 10 2023, 7:14 PM

Harbormaster completed remote builds in B50824: Diff 120112.Apr 10 2023, 7:14 PM

Ping? Would a simple boolean be better than a count?

In D39493#905461, @jhibbits wrote:

Ping? Would a simple boolean be better than a count?

grep the code it seems hv_netvsc(4) is the only consumer of this, and it is used in the slow path (configuration). Then the boolean one will be much simpler and straight.

I do not have strong options. Either a count or boolean is OK.

CC @glebius if he has some thought about this.