x11/wmenu: New port
ClosedPublic
Actions

Authored by jrm on Mar 23 2023, 1:48 PM.

Details

Reviewers

gor_clogic.com.ua
jbeich
diizzy

Commits

R11:d7abce9e0506: x11/wmenu: New port

Summary

wmenu is an efficient dynamic menu for Sway and wlroots based Wayland
compositors. It provides a Wayland-native dmenu replacement which
maintains the look and feel of dmenu. It requires wlr_layer_shell_v1
support.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50543
Build 47434: arc lint + arc unit

Event Timeline

jrm created this revision.Mar 23 2023, 1:48 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 23 2023, 1:48 PM

jrm requested review of this revision.Mar 23 2023, 1:48 PM

Harbormaster completed remote builds in B50542: Diff 119335.Mar 23 2023, 1:48 PM

Add missing period at the end of the COMMENT.

Harbormaster completed remote builds in B50543: Diff 119336.Mar 23 2023, 1:54 PM

Err.. no. There shouldn't be a period at the end fo the COMMENT.

Harbormaster completed remote builds in B50544: Diff 119338.Mar 23 2023, 2:06 PM

jrm added a reviewer: diizzy.Mar 23 2023, 2:08 PM

If it passes Poudriere, LGTM
I guess you could drop the It requires wlr_layer_shell_v1 support. from pkg-descr

diizzy accepted this revision.Mar 24 2023, 8:02 PM

This revision is now accepted and ready to land.Mar 24 2023, 8:02 PM

jbeich accepted this revision.Mar 24 2023, 8:32 PM

jbeich added inline comments.

x11/wmenu/Makefile
8	Maybe replace `Sway and wlroots` with generic `Wayland` to match upstream project summary. It'd be similar to Alpine Linux package. Note, wlr-layer-shell is also supported by Plasma and Mir, to be standardized as ext-layer-shell.
9	Maybe drop `git.` part as https://sr.ht/~adnano/wmenu/ also exists and makes it easy to find bug tracker ("tickets" tab). It'd be similar to Void Linux package.