Differential D38967

tftpd: Don't consume arbitrary requests when failing to fork.
ClosedPublic
Actions

Authored by des on Mar 7 2023, 11:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 3, 8:42 AM

	Unknown Object (File)
	Thu, Sep 3, 6:06 AM

	Unknown Object (File)
	Wed, Sep 2, 11:50 AM

	Unknown Object (File)
	Wed, Sep 2, 3:23 AM

	Unknown Object (File)
	Wed, Sep 2, 3:17 AM

	Unknown Object (File)
	Wed, Sep 2, 3:09 AM

	Unknown Object (File)
	Wed, Sep 2, 2:35 AM

	Unknown Object (File)
	Mon, Aug 31, 2:55 AM

Subscribers

None

Details

Reviewers

imp
jhb
markj

Group Reviewers

Commits

rGb4736c90adb8: tftpd: Don't consume arbitrary requests when failing to fork.

Summary

We've already consumed one request, which is sufficient to prevent inetd from endlessly restarting us in this particular and extremely unlikely case.

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50214
Build 47106: arc lint + arc unit

Event Timeline

des requested review of this revision.Mar 7 2023, 11:04 PM

des created this revision.

Harbormaster completed remote builds in B50214: Diff 118503.Mar 7 2023, 11:04 PM

des added a parent revision: D38966: tftpd: Use poll() instead of alarm() + setjmp()..Mar 7 2023, 11:04 PM

des added a child revision: D38968: tftpd: Don't forget to close stderr on startup..

markj accepted this revision as: markj.Mar 8 2023, 2:56 PM

This revision is now accepted and ready to land.Mar 8 2023, 2:56 PM

Closed by commit rGb4736c90adb8: tftpd: Don't consume arbitrary requests when failing to fork. (authored by des). · Explain WhyMar 10 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb4736c90adb8: tftpd: Don't consume arbitrary requests when failing to fork..

Revision Contents
Changeset List

Path

Size

libexec/

tftpd/

52 lines

Diff 118503

libexec/tftpd/tftpd.c

Loading...