tcp: Remove a couple of always-false checks from syncache_socket()
ClosedPublic
Actions

Authored by markj on Feb 5 2023, 9:05 PM.

Details

Reviewers

glebius
tuexen

Group Reviewers

transport

Commits

rGe6aba98fddf8: tcp: Remove a couple of always-false checks from syncache_socket()

Summary

syncache_socket() does some unnecessary work: before connecting the PCB,
it saves the local address on the stack and restores it before freeing
the PCB in case of an error. However:

There's no need to restore the old address in the error case.
The PCB's local address will always be equal to that of the syncache entry anyway.

So just remove this unnecessary code, which appears to date from the
introduction of the syncache 20+ years ago.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49541
Build 46431: arc lint + arc unit

Event Timeline

markj created this revision.Feb 5 2023, 9:05 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptFeb 5 2023, 9:05 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

markj requested review of this revision.Feb 5 2023, 9:05 PM

Harbormaster completed remote builds in B49541: Diff 116543.Feb 5 2023, 9:05 PM

tuexen accepted this revision.Feb 5 2023, 9:15 PM

This revision is now accepted and ready to land.Feb 5 2023, 9:15 PM

glebius accepted this revision.Feb 6 2023, 5:22 PM

Closed by commit rGe6aba98fddf8: tcp: Remove a couple of always-false checks from syncache_socket() (authored by markj). · Explain WhyFeb 7 2023, 8:24 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe6aba98fddf8: tcp: Remove a couple of always-false checks from syncache_socket().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

16 lines

Diff 116543

View Options

sys/netinet/tcp_syncache.c

tcp: Remove a couple of always-false checks from syncache_socket()ClosedPublicActions