Page MenuHomeFreeBSD
Differential D37855

Mechanically convert if_hn(4) to DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 22 2022, 3:37 PM.
Tags
None
Referenced Files
F133525525: D37855.id.diff
Sun, Oct 26, 10:14 AM
F133498437: D37855.diff
Sun, Oct 26, 5:44 AM
Unknown Object (File)
Sat, Oct 25, 11:38 AM
Unknown Object (File)
Sat, Oct 25, 5:16 AM
Unknown Object (File)
Sat, Oct 25, 12:35 AM
Unknown Object (File)
Thu, Oct 23, 4:11 PM
Unknown Object (File)
Sun, Oct 19, 2:15 PM
Unknown Object (File)
Sep 22 2025, 12:10 AM
View All Files
Subscribers
imp
zlei

Details

Reviewers
whu
zlei
Commits
rG4db5958a0691: Mechanically convert if_hn(4) to IfAPI

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48867
Build 45756: arc lint + arc unit

Event Timeline

jhibbits created this revision.Dec 22 2022, 3:37 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 3:37 PM
jhibbits requested review of this revision.Dec 22 2022, 3:37 PM
Harbormaster completed remote builds in B48867: Diff 114481.Dec 22 2022, 3:37 PM
jhibbits added a parent revision: D37854: Mechanically convert if_plip(4) to DrvAPI.Dec 22 2022, 3:37 PM
jhibbits added a child revision: D37856: Mechanically convert qlnx(4) to DrvAPI.
jhibbits added a reviewer: whu.Jan 5 2023, 8:46 PM
zlei added a subscriber: zlei.Feb 7 2023, 10:15 AM
zlei added inline comments.
sys/dev/hyperv/netvsc/if_hn.c
956

in if_llmaddr_count() there's check against AF_LINK, is this line change identical ?

u_int   
if_llmaddr_count(if_t ifp)
{       
...
        CK_STAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link)
                 if (ifma->ifma_addr->sa_family == AF_LINK)
                         count++;
...
        return (count);
}
1359

Set flags to wrong if. Should be VF.

1925

"in transparent VF mode.\n" is truncated.

1948

Should use if_name()

1967

if_getinputfn()

2070
2101
SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "tso_max",
	    CTLFLAG_RD, &ifp->if_hw_tsomax, 0, "max TSO size");

tso_max sysctl node is readonly, is if_sethwtsomax() really needed ?

2120

Ditto

2139

Ditto

4109

CC @whu
Originally use atomic_clear_int(), is the change sufficient ?

5878

Atomics @whu

jhibbits marked 8 inline comments as done.Feb 14 2023, 7:51 PM
jhibbits added inline comments.
sys/dev/hyperv/netvsc/if_hn.c
956

You're right. Maybe I need a new API, if_has_multi(), for this.

2101

Oops, I misread the sysctl declaration.

jhibbits updated this revision to Diff 120822.Apr 21 2023, 5:13 PM
jhibbits marked an inline comment as done.

Update diff after (several) rebases. Intended to do this 2 months ago. I hope I've addressed everything.

Harbormaster completed remote builds in B51099: Diff 120822.Apr 21 2023, 5:13 PM
zlei accepted this revision.Apr 26 2023, 2:34 AM

Generally looks good to me, once D39493 is committed.

sys/dev/hyperv/netvsc/if_hn.c
956
2107
2119
This revision is now accepted and ready to land.Apr 26 2023, 2:34 AM
Closed by commit rG4db5958a0691: Mechanically convert if_hn(4) to IfAPI (authored by jhibbits). · Explain WhyMay 2 2023, 6:47 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG4db5958a0691: Mechanically convert if_hn(4) to IfAPI.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
netvsc/
675 lines
10 lines

Diff 114481

View Options

sys/dev/hyperv/netvsc/if_hn.c

Loading...
View Options

sys/dev/hyperv/netvsc/if_hnvar.h

Loading...