Page MenuHomeFreeBSD
Differential D4595

hyperv: vmbus: hv_vmbus_channel_msg_type: remove unused definitions
ClosedPublic
Actions

Authored by decui_microsoft.com on Dec 16 2015, 1:43 PM.
Tags
None
Referenced Files
F167348773: D4595.id11346.diff
Fri, Aug 21, 4:05 AM
Unknown Object (File)
Thu, Aug 13, 9:09 PM
Unknown Object (File)
Thu, Aug 13, 9:09 PM
Unknown Object (File)
Thu, Aug 13, 9:09 PM
Unknown Object (File)
Tue, Aug 11, 9:02 PM
Unknown Object (File)
Tue, Aug 4, 4:11 AM
Unknown Object (File)
Mon, Aug 3, 3:21 AM
Unknown Object (File)
Thu, Jul 30, 2:00 PM
View All Files
Subscribers
imp

Details

Reviewers
kmacy
howard0su_gmail.com
honzhan_microsoft.com
whu
delphij
sepherosa_gmail.com
royger
adrian
Commits
rS293871: hyperv: remove unused vmbus definitions
Summary

We don't need them at all.

Signed-off-by: Dexuan Cui <decui@microsoft.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1694
Build 1700: arc lint + arc unit

Event Timeline

decui_microsoft.com updated this revision to Diff 11346.Dec 16 2015, 1:43 PM
decui_microsoft.com retitled this revision from to hyperv: vmbus: hv_vmbus_channel_msg_type: remove unused definitions.
decui_microsoft.com updated this object.
decui_microsoft.com added reviewers: whu, royger, delphij, kmacy, howard0su_gmail.com, honzhan_microsoft.com.
Herald added a subscriber: imp. · View Herald TranscriptDec 16 2015, 1:43 PM
royger accepted this revision.Dec 23 2015, 4:29 PM
royger edited edge metadata.

LGTM. This made me wonder, is there some kind of canonical source for the HyperV headers? Or it's mostly ad-hoc for each OS?

This revision is now accepted and ready to land.Dec 23 2015, 4:29 PM
royger added a comment.Dec 23 2015, 4:30 PM

Forgot to mention, on FreeBSD you don't have to add a Signed-off-by tag to commit messages.

decui_microsoft.com added a comment.Dec 24 2015, 3:06 PM
In D4595#99077, @royger wrote:

Forgot to mention, on FreeBSD you don't have to add a Signed-off-by tag to commit messages.

Thanks Roger for the reminder. I won't add Signed-off-by in future.

decui_microsoft.com added a comment.Dec 24 2015, 3:12 PM
In D4595#99073, @royger wrote:

LGTM. This made me wonder, is there some kind of canonical source for the HyperV headers? Or it's mostly ad-hoc for each OS?

Thanks for reviewing the patch. I don't know about such a source. Xin Li should know the history of the drivers better than me.

decui_microsoft.com added a reviewer: sepherosa_gmail.com.Jan 8 2016, 10:19 AM
delphij accepted this revision.Jan 13 2016, 3:06 AM
delphij edited edge metadata.
adrian accepted this revision.Jan 13 2016, 7:07 PM
adrian added a reviewer: adrian.
Closed by commit rS293871: hyperv: remove unused vmbus definitions (authored by sephe). · Explain WhyJan 14 2016, 2:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
include/
5 lines

Diff 11346

View Options

sys/dev/hyperv/include/hyperv.h

Loading...