Page MenuHomeFreeBSD
Differential D37292

bhyve: Drop volatile qualifiers from snapshot code
ClosedPublic
Actions

Authored by markj on Nov 6 2022, 7:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 1:14 AM
Unknown Object (File)
Sat, Mar 29, 9:19 AM
Unknown Object (File)
Thu, Mar 27, 8:08 AM
Unknown Object (File)
Feb 23 2025, 2:58 AM
Unknown Object (File)
Feb 20 2025, 12:18 PM
Unknown Object (File)
Jan 30 2025, 9:57 AM
Unknown Object (File)
Jan 27 2025, 4:57 PM
Unknown Object (File)
Jan 27 2025, 4:54 PM
View All 65 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
corvink
Group Reviewers
bhyve
Commits
rG385e330c1c5d: bhyve: Drop volatile qualifiers from snapshot code
rG8b1adff8bcbd: bhyve: Drop volatile qualifiers from snapshot code
Summary

They accomplish nothing since the qualifier is casted away in calls to
memcpy() and copyin()/copyout(). No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
10 lines
vmm/
17 lines
usr.sbin/
bhyve/
14 lines

Diff 112937

View Options

sys/amd64/include/vmm_snapshot.h

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

sys/amd64/vmm/vmm_snapshot.c

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

usr.sbin/bhyve/snapshot.c

Show All 18 Lines
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd July 9, 2016 .Dd February 27, 2017
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
.Nm bhyve .Nm bhyve
.Nd "run a guest operating system inside a virtual machine" .Nd "run a guest operating system inside a virtual machine"
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl abehuwxACHPSWY .Op Fl abehuwxACHPSWY
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.It Li passthru .It Li passthru
PCI pass-through device. PCI pass-through device.
.It Li virtio-net .It Li virtio-net
Virtio network interface. Virtio network interface.
.It Li virtio-blk .It Li virtio-blk
Virtio block storage interface. Virtio block storage interface.
.It Li virtio-rnd .It Li virtio-rnd
Virtio RNG interface. Virtio RNG interface.
.It Li virtio-console
Virtio console interface, which exposes multiple ports
to the guest in the form of simple char devices for simple IO
between the guest and host userspaces.
.It Li ahci .It Li ahci
AHCI controller attached to arbitrary devices. AHCI controller attached to arbitrary devices.
.It Li ahci-cd .It Li ahci-cd
AHCI controller attached to an ATAPI CD/DVD. AHCI controller attached to an ATAPI CD/DVD.
.It Li ahci-hd .It Li ahci-hd
AHCI controller attached to a SATA hard-drive. AHCI controller attached to a SATA hard-drive.
.It Li e1000 .It Li e1000
Intel e82545 network interface. Intel e82545 network interface.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
Guest memory must be wired using the Guest memory must be wired using the
.Fl S .Fl S
option when a pass-through device is configured. option when a pass-through device is configured.
.Pp .Pp
The host device must have been reserved at boot-time using the The host device must have been reserved at boot-time using the
.Va pptdev .Va pptdev
loader variable as described in loader variable as described in
.Xr vmm 4 . .Xr vmm 4 .
.Pp
Virtio console devices:
.Bl -tag -width 10n
.It Li port1= Ns Pa /path/to/port1.sock Ns ,anotherport= Ns Pa ...
A maximum of 16 ports per device can be created.
Every port is named and corresponds to a Unix domain socket created by
.Nm .
.Nm
accepts at most one connection per port at a time.
.Pp
Limitations:
.Bl -bullet -offset 2n
.It
Due to lack of destructors in
.Nm ,
sockets on the filesystem must be cleaned up manually after
.Nm
exits.
.It
There is no way to use the "console port" feature, nor the console port
resize as of now.
wblockUnsubmitted
Not Done
Inline Actions

Recommend "at present" rather than "as of now".

wblock: Recommend "at present" rather than "as of now".
novelAuthorUnsubmitted
Not Done
Inline Actions

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

novel: Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you…
wblockUnsubmitted
Not Done
Inline Actions

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

wblock: Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no…
novelAuthorUnsubmitted
Not Done
Inline Actions

Thanks, I've just committed that.

novel: Thanks, I've just committed that.
.It
Emergency write is advertised, but no-op as of now.
wblockUnsubmitted
Not Done
Inline Actions

Likewise, "at present" is simpler and clearer.

wblock: Likewise, "at present" is simpler and clearer.
.El
.El
.El .El
.It Fl S .It Fl S
Wire guest memory. Wire guest memory.
.It Fl u .It Fl u
RTC keeps UTC time. RTC keeps UTC time.
.It Fl U Ar uuid .It Fl U Ar uuid
Set the universally unique identifier Set the universally unique identifier
.Pq UUID .Pq UUID
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines