Some auditing of the code shows that "cred" is never non-NULL in these
functions, either because all callers pass a non-NULL reference or
because they unconditionally dereference "cred". So, let's simplify the
code a bit and remove NULL checks. No functional change intended.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 47862 Build 44749: arc lint + arc unit
Event Timeline
| sys/netinet/in_pcb.c | ||
|---|---|---|
| 1171 | May be add documenting MPASS(cred) here and in other functions? | |
| sys/netinet/in_pcb.c | ||
|---|---|---|
| 1171 | If you really prefer it I will do it, but to me it's overkill. These functions are not providing general-purpose interfaces, so it's ok to make assumptions like this IMO. | |
| sys/netinet/in_pcb.c | ||
|---|---|---|
| 1171 | Just suggested! If you disagree, let it be your way :) | |