Page MenuHomeFreeBSD
Differential D36752

Fix various places which cast a pointer to a uint64_t or vice versa.
ClosedPublic
Actions

Authored by jhb on Sep 27 2022, 5:36 PM.
Tags
None
Referenced Files
F154323645: D36752.id.diff
Mon, Apr 27, 8:31 PM
F154317507: D36752.id111092.diff
Mon, Apr 27, 7:29 PM
Unknown Object (File)
Mon, Apr 20, 8:00 AM
Unknown Object (File)
Sat, Apr 18, 2:56 PM
Unknown Object (File)
Mar 18 2026, 2:29 AM
Unknown Object (File)
Mar 18 2026, 2:21 AM
Unknown Object (File)
Mar 17 2026, 9:05 AM
Unknown Object (File)
Feb 9 2026, 5:11 AM
View All 89 Files
Subscribers
delphij
imp

Details

Reviewers
whu
markj
mm
imp
Commits
rGc5eed4146fc9: Fix various places which cast a pointer to a uint64_t or vice versa.
Summary

GCC warns about the mismatched sizes on 32-bit platforms.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47567
Build 44454: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 27 2022, 5:36 PM
Herald added subscribers: delphij, imp. · View Herald TranscriptSep 27 2022, 5:36 PM
jhb requested review of this revision.Sep 27 2022, 5:36 PM
Harbormaster completed remote builds in B47567: Diff 111092.Sep 27 2022, 5:37 PM
jhb added a reviewer: mm.Sep 27 2022, 5:40 PM
imp accepted this revision.Sep 27 2022, 6:19 PM
imp added inline comments.
sys/dev/iser/iser_initiator.c
293

Dropping the extra cast may lead to warnings when sizeof(uintptr_t) != sizeof(size_t)

This revision is now accepted and ready to land.Sep 27 2022, 6:19 PM
imp added inline comments.Sep 27 2022, 6:20 PM
sys/dev/iser/iser_initiator.c
293

I tried to delete this comment, since it turned out to be wrong.

jhb added inline comments.Sep 27 2022, 6:21 PM
sys/dev/iser/iser_initiator.c
293

Only CHERI has those and it's actually more well-defined to add offsets (size_t or ptrdiff_t) to pointers than to add two pointers together.

markj accepted this revision.Sep 27 2022, 6:57 PM
Closed by commit rGc5eed4146fc9: Fix various places which cast a pointer to a uint64_t or vice versa. (authored by jhb). · Explain WhySep 28 2022, 9:06 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGc5eed4146fc9: Fix various places which cast a pointer to a uint64_t or vice versa..

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
os/
freebsd/
zfs/
2 lines
dev/
iser/
2 lines
mana/
8 lines
4 lines

Diff 111092

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/kmod_core.c

Loading...
View Options

sys/dev/iser/iser_initiator.c

Loading...
View Options

sys/dev/mana/gdma_main.c

Loading...
View Options

sys/dev/mana/hw_channel.c

Loading...