tcp: allow RACK to be loaded when cc_newreno is not compiled into the kernel
ClosedPublic
Actions

Authored by tuexen on Sep 25 2022, 11:26 PM.

Details

Reviewers

rrs
rscheff

Group Reviewers

transport

Commits

rG0fdc24727429: tcp: make RACK loadable again using the default configuration

Summary

The RACK stack depends on newreno_beta_ecn. So declare it in cc.c instead of cc_newreno.c. This is relevant since cc_newreno is not the default anymore...

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 25 2022, 11:26 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 25 2022, 11:26 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Sep 25 2022, 11:26 PM

In accordance with https://www.rfc-editor.org/rfc/rfc8511.html, should these two sysctls keep the newreno_ moniker? Or renamed to "beta_loss" and "beta_ecn"?

rscheff accepted this revision.Sep 26 2022, 7:49 AM

This revision is now accepted and ready to land.Sep 26 2022, 7:49 AM

In D36707#833421, @rscheff wrote:

In accordance with https://www.rfc-editor.org/rfc/rfc8511.html, should these two sysctls keep the newreno_ moniker? Or renamed to "beta_loss" and "beta_ecn"?

We can (right now) keep the newreno prefix, since it is only needed for newreno, I think. The RACK stack uses it only for cc_newreno.