ip_output: always increase "cantfrag" stat if ip_fragment() fails
ClosedPublic
Actions

Authored by glebius on Sep 14 2022, 9:21 PM.

Tags

None

Referenced Files

	F163249978: D36584.id110586.diff
	Tue, Jul 21, 10:19 AM

	Unknown Object (File)
	Jun 15 2026, 11:50 PM

	Unknown Object (File)
	Jun 7 2026, 10:14 PM

	Unknown Object (File)
	May 9 2026, 5:00 PM

	Unknown Object (File)
	May 9 2026, 9:37 AM

	Unknown Object (File)
	May 8 2026, 8:02 PM

	Unknown Object (File)
	May 6 2026, 10:49 PM

	Unknown Object (File)
	May 6 2026, 7:03 PM

View All Files

Subscribers

imp

melifaro

Details

Reviewers

mjg
melifaro

Group Reviewers

network

Commits

rGda6715bbb125: ip_output: always increase "cantfrag" stat if ip_fragment() fails

Summary

While here, join two unlikely cases into one if clause.

Submitted by: Ivan Rozhuk <rozhuk.im gmail.com>
PR: 265718

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Sep 14 2022, 9:21 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 14 2022, 9:21 PM

glebius requested review of this revision.Sep 14 2022, 9:21 PM

Harbormaster completed remote builds in B47400: Diff 110578.Sep 14 2022, 9:22 PM

mjg accepted this revision as: mjg.Sep 14 2022, 10:51 PM

This revision is now accepted and ready to land.Sep 14 2022, 10:51 PM

melifaro accepted this revision.Sep 14 2022, 11:16 PM

Closed by commit rGda6715bbb125: ip_output: always increase "cantfrag" stat if ip_fragment() fails (authored by glebius). · Explain WhySep 15 2022, 2:23 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGda6715bbb125: ip_output: always increase "cantfrag" stat if ip_fragment() fails.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_output.c

14 lines

Diff 110586

View Options

ip_output: always increase "cantfrag" stat if ip_fragment() failsClosedPublicActions