acpi: arm64 doesn't support ACPI 1.0 RSDP, report when we see one
ClosedPublic
Actions

Authored by imp on Aug 31 2022, 3:58 PM.

Details

Reviewers

jhb
manu
andrew

Commits

rG195f794318a3: acpi: arm64 doesn't support ACPI 1.0 RSDP, report when we see one

Summary

arm64 requires ACPI RSDP Revision 2.0 since it requires 64-bit physical
addresses. It is an error worth reporting if we have a RSDP pointer, but
it points to the wrong version.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47203
Build 44090: arc lint + arc unit

Event Timeline

imp created this revision.Aug 31 2022, 3:58 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 31 2022, 3:58 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

imp requested review of this revision.Aug 31 2022, 3:58 PM

Harbormaster completed remote builds in B47203: Diff 110018.Aug 31 2022, 3:58 PM

imp added a reviewer: andrew.Aug 31 2022, 4:00 PM

jlduran added a subscriber: jlduran.Aug 31 2022, 4:34 PM

jlduran added inline comments.

sys/arm64/acpica/acpi_machdep.c
198	minor typo: Unsupported.

fix trivial typo

Harbormaster completed remote builds in B47207: Diff 110022.Aug 31 2022, 5:18 PM

andrew accepted this revision.Sep 1 2022, 9:38 AM

This revision is now accepted and ready to land.Sep 1 2022, 9:38 AM

Closed by commit rG195f794318a3: acpi: arm64 doesn't support ACPI 1.0 RSDP, report when we see one (authored by imp). · Explain WhySep 1 2022, 4:43 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG195f794318a3: acpi: arm64 doesn't support ACPI 1.0 RSDP, report when we see one.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

acpica/

acpi_machdep.c

3 lines

Diff 110018

View Options

sys/arm64/acpica/acpi_machdep.c

acpi: arm64 doesn't support ACPI 1.0 RSDP, report when we see oneClosedPublicActions