Page MenuHomeFreeBSD

Check dtrace invop earlier, shotcut if it is dtrace fbt exception.
ClosedPublic

Authored by howard0su_gmail.com on Nov 24 2015, 1:06 PM.
Tags
None
Referenced Files
F83924500: D4266.id10516.diff
Thu, May 16, 10:28 PM
Unknown Object (File)
Wed, May 8, 2:45 PM
Unknown Object (File)
Sun, May 5, 7:38 PM
Unknown Object (File)
Sat, May 4, 9:22 PM
Unknown Object (File)
Sat, May 4, 8:17 PM
Unknown Object (File)
Sat, May 4, 8:12 PM
Unknown Object (File)
Sat, May 4, 1:05 PM
Unknown Object (File)
Sat, May 4, 1:05 PM
Subscribers

Details

Summary

Check invop of dtrace inside exception.S to reduce overhead to
call into C code. also check this earlier also reduce unnecessary
overhead.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1351
Build 1356: arc lint + arc unit

Event Timeline

howard0su_gmail.com retitled this revision from to Check dtrace invop earlier, shotcut if it is dtrace fbt exception..
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)

You will also need to adjust the number of frames to skip in DTrace when running a stack trace as there is not one fewer.

sys/arm/arm/exception.S
376

This should use PSR_USR32_MODE

380–387

In l41BSD we moved this to the C handler

390

Move FBT_PATCHVAL from sys/cddl/dev/fbt/arm/fbt_isa.c to trap.h and use this here. You should also rename it to something like FBT_BREAKPOINT. We need to be able to tell the difference between DTrace and DDB breakpoint instructions.

howard0su_gmail.com edited edge metadata.

Check dtrace invop earlier, shotcut if it is dtrace fbt exception.

it can enable fbt under VERSATILEPB. But still has issue when I try to sysctl kern.kdb.enter=1, i hit kernel stack overflow.

sys/arm/arm/exception.S
380–387

we have to do here since I want to check the INSN in assembly.

Check dtrace invop earlier, shotcut if it is dtrace fbt exception.

sys/arm/arm/exception.S
397

This is only needed in the non-KDTRACE_HOOKS case.

sys/arm/include/trap.h
10

It should be named FBT_BREAKPOINT, and there is no need for the comment.

Fix 5th parameter add Dtrace support to trap-v6 code.

andrew edited edge metadata.

Unless someone has any objections I'm planning on committing this tomorrow.

This revision is now accepted and ready to land.Nov 30 2015, 11:44 PM
howard0su_gmail.com edited edge metadata.

Rename FBT_PATCHVAL to FBT_BREAKPOINT

This revision now requires review to proceed.Dec 1 2015, 12:39 AM
howard0su_gmail.com edited edge metadata.

Rename FBT_PATCHVAL to FBT_BREAKPOINT

This revision was automatically updated to reflect the committed changes.