bhyve - snapshot capsicum integration[Part 3]
AbandonedPublic
Actions

Authored by ionut.mihalache1506_gmail.com on Mar 17 2022, 2:41 PM.

Details

Reviewers

None

Group Reviewers

bhyve
capsicum

Summary

This is the third part for the capsicum integration. It provides changes regarding the rebase process with a newer version for bhyve and it eliminates some changes that are unnecessary.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ionut.mihalache1506_gmail.com created this revision.Mar 17 2022, 2:41 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 17 2022, 2:41 PM

Herald added subscribers: bcran, rgrimes, emaste. · View Herald Transcript

ionut.mihalache1506_gmail.com requested review of this revision.Mar 17 2022, 2:41 PM

ionut.mihalache1506_gmail.com added a parent revision: D34586: bhyve - snapshot capsicum integration[Part 2].

lwhsu added a reviewer: capsicum.Mar 17 2022, 5:15 PM

lwhsu added a subscriber: lwhsu.

lwhsu added inline comments.

Makefile.inc1
2782	this seems already in the latest code, maybe missed in rebase?

Made the necessary changes to the solution in order to solve a issue mentioned by @rew(there is a problem when the first disk uses /dev/md0. Instead of using the parent directory of the first disk, now the snapshot directory can be specified at boot time using -t option.
I also did refactor the code to remove unnecessary/unused parts before and after the changes.

Herald added a subscriber: jonathan. · View Herald TranscriptMar 23 2022, 2:04 PM

ionut.mihalache1506_gmail.com added a subscriber: elenamihailescu22_gmail.com.Mar 30 2022, 8:43 AM

andy_omniosce.org added a subscriber: andy_omniosce.org.Mar 30 2022, 9:08 AM

andy_omniosce.org added inline comments.

usr.sbin/bhyve/snapshot.c
1650	Can you be consistent about these things being bracketed in #ifndef WITHOUT_CAPSICUM ? The `#endif` just above here closes the previous conditional block.