Page MenuHomeFreeBSD
Differential D34213

powerpc: Add static asssert for context size
ClosedPublic
Actions

Authored by imp on Feb 8 2022, 10:04 PM.
Tags
None
Referenced Files
F111561031: D34213.id102624.diff
Wed, Mar 5, 7:07 AM
Unknown Object (File)
Sun, Feb 23, 6:13 PM
Unknown Object (File)
Sun, Feb 9, 10:45 PM
Unknown Object (File)
Thu, Feb 6, 7:23 AM
Unknown Object (File)
Thu, Feb 6, 4:36 AM
Unknown Object (File)
Jan 30 2025, 5:34 PM
Unknown Object (File)
Jan 19 2025, 5:11 AM
Unknown Object (File)
Jan 10 2025, 12:59 AM
View All 70 Files
Subscribers
jhibbits

Details

Reviewers
jhb
andrew
kib
manu
mhorne
emaste
Commits
rG6e48e160ae93: powerpc: Add static asssert for context size
Summary

Add a static assert for the mcontext_t and ucontext_t sizes. These are
de-facto ABI options and cannot change size ever. For powerpc64, also
add asserts for {u,m}mcontext32_t.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44397
Build 41285: arc lint + arc unit

Event Timeline

imp created this revision.Feb 8 2022, 10:04 PM
Herald added a subscriber: jhibbits. · View Herald TranscriptFeb 8 2022, 10:04 PM
imp requested review of this revision.Feb 8 2022, 10:04 PM
imp added a parent revision: D34212: amd64: Add static asssert for context size.
imp added a child revision: D34214: riscv: Add static asssert for context size.
Harbormaster completed remote builds in B44349: Diff 102522.Feb 8 2022, 10:05 PM
imp updated this revision to Diff 102535.Feb 9 2022, 12:00 AM

update per review

Harbormaster completed remote builds in B44360: Diff 102535.Feb 9 2022, 12:00 AM
andrew accepted this revision.Feb 9 2022, 2:38 PM
andrew added inline comments.
sys/powerpc/powerpc/exec_machdep.c
135

Shouldn't this message be ucontext_t ...?

144

And here

This revision is now accepted and ready to land.Feb 9 2022, 2:38 PM
imp updated this revision to Diff 102624.Feb 10 2022, 7:31 PM

update per review

This revision now requires review to proceed.Feb 10 2022, 7:31 PM
Harbormaster completed remote builds in B44397: Diff 102624.Feb 10 2022, 7:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2022, 9:34 PM
Closed by commit rG6e48e160ae93: powerpc: Add static asssert for context size (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG6e48e160ae93: powerpc: Add static asssert for context size.

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powerpc/
15 lines

Diff 102624

View Options

sys/powerpc/powerpc/exec_machdep.c

Loading...