Page MenuHomeFreeBSD

riscv: Add static asssert for context size
ClosedPublic

Authored by imp on Feb 8 2022, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 11:30 PM
Unknown Object (File)
Mon, Apr 8, 9:42 PM
Unknown Object (File)
Mar 20 2024, 10:39 AM
Unknown Object (File)
Mar 19 2024, 3:34 PM
Unknown Object (File)
Mar 19 2024, 3:00 PM
Unknown Object (File)
Feb 25 2024, 3:02 AM
Unknown Object (File)
Feb 8 2024, 3:02 PM
Unknown Object (File)
Feb 6 2024, 8:01 PM
Subscribers
None

Details

Summary

Add a static assert for the mcontext_t and ucontext_t sizes. These are
de-factor ABI options and cannot change size ever.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 8 2022, 10:05 PM
imp created this revision.

update, per review (for real this time)

IMO "has incorrect size" would be more clear than "bogusly changed size"

IMO "has incorrect size" would be more clear than "bogusly changed size"

I'll make this change globally across all the reviews, but I won't upload them again unless other changes are needed.
Reviewers should assume that change is made.

I'll make this change globally across all the reviews, but I won't upload them again unless other changes are needed.

👍

sys/riscv/riscv/exec_machdep.c
81

Shouldn't this message be ucontext_t ...?

This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2022, 9:35 PM
This revision was automatically updated to reflect the committed changes.