Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 7:09 AM
Unknown Object (File)
Tue, Aug 25, 10:04 PM
Unknown Object (File)
Tue, Aug 25, 2:56 PM
Unknown Object (File)
Tue, Aug 25, 2:27 PM
Unknown Object (File)
Mon, Aug 24, 11:43 PM
Unknown Object (File)
Mon, Aug 24, 8:53 PM
Unknown Object (File)
Sun, Aug 23, 10:29 PM
Unknown Object (File)
Sun, Aug 23, 8:09 PM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44032
Build 40920: arc lint + arc unit